Add toggle for custom_from_subdomain DNS record creation #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarkis
force-pushed
the
add-custom-subdomain-record-toggle
branch
2 times, most recently
from
aa2fbcd
to
0e4cd7f
Compare
osterman
reviewed
Oct 11, 2024
sarkis
force-pushed
the
add-custom-subdomain-record-toggle
branch
from
0e4cd7f
to
9528458
Compare
|
bump ... is there anything else I can do to further this along to the next set of checks? |
|
I'm checking with the team |
|
/terratest |
Benbentwo
approved these changes
Oct 30, 2024
|
/terratest |
Benbentwo
approved these changes
Oct 30, 2024
|
/terratest |
Benbentwo
approved these changes
Oct 30, 2024
osterman
approved these changes
Oct 30, 2024
|
These changes were released in v0.25.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
This module currently has no way to disable the custom_from_domain Route53 records from being created. Add a new variable
create_custom_from_subdomain_recordand default it totrueto preserve the current behavior. Allows users that need this feature to toggle the option to false and get the desired results.why
This is a problem for organizations that will need to manage DNS records outside of Route53 or in a different AWS account. Currently, other records in the module have a toggle, but the one for
custom_from_subdomainseems to have been missed.references
closes #98