Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests #86

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Fix tests #86

merged 3 commits into from
Mar 19, 2024

Conversation

joe-niland
Copy link
Member

what

  • update vpc version in examples

why

  • tests currently fail with the latest AWS provider

references

  • None

@joe-niland joe-niland requested review from a team as code owners March 18, 2024 03:55
@mergify mergify bot added the triage Needs triage label Mar 18, 2024
@joe-niland
Copy link
Member Author

/terratest

gberenice
gberenice approved these changes Mar 19, 2024
View reviewed changes
Copy link

@gberenice gberenice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gberenice gberenice merged commit 93251d8 into cloudposse:main Mar 19, 2024
11 checks passed
@mergify mergify bot removed the triage Needs triage label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gberenice gberenice gberenice approved these changes

@kevcube kevcube Awaiting requested review from kevcube kevcube is a code owner automatically assigned from cloudposse/contributors

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem is a code owner automatically assigned from cloudposse/contributors

@hans-d hans-d Awaiting requested review from hans-d

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joe-niland @gberenice