Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional SPF record and custom FROM domain #81

Merged
merged 10 commits into from
Mar 21, 2024
Merged

Add optional SPF record and custom FROM domain #81

merged 10 commits into from
Mar 21, 2024

Conversation

joe-niland
Copy link
Member

@joe-niland joe-niland commented Mar 8, 2024 •
edited
Loading

what

  • Add ability to create an SPF record for the domain identity
  • Add ability to create a custom FROM subdomain for the domain entity
  • Increase TTL on DKIM and SES verification records in line with recommendations from DNS service providers (e.g. https://www.digicert.com/faq/dns/what-is-ttl)

why

  • An SPF record improves email deliverability and makes it more difficult to use the domain in an email spoofing attempt.
  • Sending mail from a subdomain of the verified domain improves SPAM score (HEADER_FROM_DIFFERENT_DOMAINS)
  • Reduce DNS query volume on mainly static records

references

None

@joe-niland joe-niland requested review from a team as code owners March 8, 2024 02:53
@joe-niland
Copy link
Member Author

/terratest

1 similar comment
@joe-niland
Copy link
Member Author

/terratest

@joe-niland
Copy link
Member Author

/terratest

1 similar comment
@joe-niland
Copy link
Member Author

/terratest

@joe-niland joe-niland requested a review from hans-d March 8, 2024 03:50
@joe-niland joe-niland marked this pull request as draft March 8, 2024 05:20
hans-d
hans-d reviewed Mar 8, 2024
View reviewed changes
.github/renovate.json Outdated Show resolved Hide resolved
examples/complete/main.tf Outdated Show resolved Hide resolved
@joe-niland
Copy link
Member Author

btw this is a draft because I realised I need to add one more change to go with the SPF record

@mergify mergify bot added triage Needs triage needs-cloudposse Needs Cloud Posse assistance labels Mar 9, 2024
@mergify Mergify
Copy link

mergify bot commented Mar 9, 2024

Important

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

@mergify Mergify
Copy link

mergify bot commented Mar 9, 2024

This pull request now has conflicts. Could you fix it @joe-niland? 🙏

@mergify mergify bot added conflict This PR has conflicts needs-test Needs testing and removed conflict This PR has conflicts labels Mar 9, 2024
@joe-niland joe-niland changed the title Add optional SPF record Add optional SPF record and custom FROM domain Mar 18, 2024
@joe-niland
Add optional SPF record
cb61209 
Increase SPF TTL

Increase TTL of SES verification and DKIM records

- follow recommended values from DNS service providers

Add support for custom from domain
@joe-niland joe-niland marked this pull request as ready for review March 18, 2024 01:57
@joe-niland
Copy link
Member Author

/terratest

@joe-niland joe-niland requested a review from hans-d March 18, 2024 02:00
@joe-niland
Copy link
Member Author

@hans-d thanks - changes made as requested

@joe-niland
Copy link
Member Author

/terratest

@joe-niland
Copy link
Member Author

/terratest

@joe-niland
Copy link
Member Author

@Mergifyio refresh

@mergify Mergify
Copy link

mergify bot commented Mar 19, 2024

refresh

✅ Pull request refreshed

@joe-niland
Copy link
Member Author

/terratest

@joe-niland joe-niland added minor New features that do not break anything and removed needs-cloudposse Needs Cloud Posse assistance labels Mar 20, 2024
@mergify mergify bot removed the triage Needs triage label Mar 20, 2024
@joe-niland joe-niland merged commit 410779d into cloudposse:main Mar 21, 2024
35 checks passed
@joe-niland joe-niland deleted the spf-record branch March 21, 2024 01:49
@joe-niland joe-niland removed the needs-test Needs testing label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milldr milldr milldr approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem is a code owner automatically assigned from cloudposse/contributors

@jamengual jamengual Awaiting requested review from jamengual jamengual is a code owner automatically assigned from cloudposse/contributors

@hans-d hans-d Awaiting requested review from hans-d

Assignees
No one assigned
Labels
minor New features that do not break anything
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joe-niland @hans-d @milldr