Chore/partitions and condition overrides

[tsaucier-sf]

what

• Add partition support for sns_kms_key_policy IAM policy.
• Add additional condition for local.enabled_standards_arns securityhub arn.

why

• Needs to support multiple available partitions
• format function fails when local.enabled is false due to data lookups not existing.

references

• Add dynamic partition to IAM ARN in KMS Key Policy #33
• Discovered when module is disabled

  Error: Error in function call │  │   on .terraform/modules/cloud_security.security_hub/main.tf line 43, in locals: │   43:     
  format("arn:%s:securityhub:%s::%s", one(data.aws_partition.this[*].partition), length(regexall("ruleset", standard)) == 0 
  ? one(data.aws_region.this[*].name) : "", standard) │     ├──────────────── │     │ data.aws_partition.this 
  is empty tuple │     │ data.aws_region.this is empty tuple │  │ Call to function "format" failed: unsupported value for "%s" at 
  4: null value cannot be formatted. ╵ ╷ │ Error: Error in function call │  │   on 
  .terraform/modules/cloud_security.security_hub/main.tf line 43, in locals: │   43:     format("arn:%s:securityhub:%s::%s", 
  one(data.aws_partition.this[*].partition), length(regexall("ruleset", standard)) == 0 ? one(data.aws_region.this[*].name) : 
  "", standard) │     ├──────────────── │     │ data.aws_partition.this is empty tuple │     │ 
  data.aws_region.this is empty tuple │  │ Call to function "format" failed: unsupported value for "%s" at 4: null value 
  cannot be formatted.
  

[hans-d]

/terratest

[hans-d]

/terratest

[hans-d]

@tsaucier-sf https://github.com/cloudposse/terraform-aws-security-hub/releases/tag/0.12.0 Thanks !