Add option to define character set #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/rebuild-readme |
|
/test all |
|
This pull request is now in conflict. Could you fix it @yariksheptykin? 🙏 |
|
/rebuild-readme |
yariksheptykin
requested review from
Makeshift and
nitrocode
and removed request for
a team
|
@yariksheptykin please, rebase the code |
yariksheptykin
force-pushed
the
add-charset-option
branch
from
13c15c0
to
f6b316d
Compare
|
/rebuild-readme |
|
Hi @maximmi , could you take a look at this MR before it becomes stale again? |
|
This pull request is now in conflict. Could you fix it @yariksheptykin? 🙏 |
|
Closing merge request because there does not seem to be much interest in this work. |
![bridgecrew[bot]](https://avatars.githubusercontent.com/in/52968?s=60&v=4){kind=small}
| @@ -29,6 +29,7 @@ resource "aws_db_instance" "default" { | |||
| port = var.database_port | |||
| engine = var.engine | |||
| engine_version = var.engine_version | |||
| character_set_name = var.charset_name | |||
There was a problem hiding this comment.
Ensure that enhanced monitoring is enabled for Amazon RDS instances
Resource: aws_db_instance.default | ID: BC_AWS_LOGGING_28
How to Fix
resource "aws_db_instance" "default" {
allocated_storage = 10
engine = "mysql"
engine_version = "5.7"
instance_class = "db.t3.micro"
name = "mydb"
username = "foo"
password = "foobarbaz"
parameter_group_name = "default.mysql5.7"
skip_final_snapshot = true
+ monitoring_interval = 5
}Description
TBADependent Resources
Calculating...
| @@ -29,6 +29,7 @@ resource "aws_db_instance" "default" { | |||
| port = var.database_port | |||
| engine = var.engine | |||
| engine_version = var.engine_version | |||
| character_set_name = var.charset_name | |||
There was a problem hiding this comment.
Ensure that RDS instances have Multi-AZ enabled
Resource: aws_db_instance.default | ID: BC_AWS_GENERAL_73
How to Fix
resource "aws_db_instance" "default" {
allocated_storage = 20
storage_type = "gp2"
engine = "mysql"
engine_version = "5.7"
instance_class = "db.t2.micro"
name = "mydb"
+ multi_az = true
}Description
Amazon RDS Multi-AZ deployments provide enhanced availability for databases within a single region. In the event of a planned or unplanned outage of your DB instance, Amazon RDS automatically switches to a standby replica in another Availability Zone if you have enabled Multi-AZ.RDS Multi-AZ deployments offer the following benefits:
- Enhanced durability.
- Increased availability.
- Protection of your database performance.
- Automatic failover.
Dependent Resources
Calculating...
| @@ -29,6 +29,7 @@ resource "aws_db_instance" "default" { | |||
| port = var.database_port | |||
| engine = var.engine | |||
| engine_version = var.engine_version | |||
| character_set_name = var.charset_name | |||
There was a problem hiding this comment.
Ensure that enhanced monitoring is enabled for Amazon RDS instances
Resource: aws_db_instance.default | ID: BC_AWS_LOGGING_28
How to Fix
resource "aws_db_instance" "default" {
allocated_storage = 10
engine = "mysql"
engine_version = "5.7"
instance_class = "db.t3.micro"
name = "mydb"
username = "foo"
password = "foobarbaz"
parameter_group_name = "default.mysql5.7"
skip_final_snapshot = true
+ monitoring_interval = 5
}Description
TBADependent Resources
Calculating...
| @@ -29,6 +29,7 @@ resource "aws_db_instance" "default" { | |||
| port = var.database_port | |||
| engine = var.engine | |||
| engine_version = var.engine_version | |||
| character_set_name = var.charset_name | |||
There was a problem hiding this comment.
Ensure that RDS instances have Multi-AZ enabled
Resource: aws_db_instance.default | ID: BC_AWS_GENERAL_73
How to Fix
resource "aws_db_instance" "default" {
allocated_storage = 20
storage_type = "gp2"
engine = "mysql"
engine_version = "5.7"
instance_class = "db.t2.micro"
name = "mydb"
+ multi_az = true
}Description
Amazon RDS Multi-AZ deployments provide enhanced availability for databases within a single region. In the event of a planned or unplanned outage of your DB instance, Amazon RDS automatically switches to a standby replica in another Availability Zone if you have enabled Multi-AZ.RDS Multi-AZ deployments offer the following benefits:
- Enhanced durability.
- Increased availability.
- Protection of your database performance.
- Automatic failover.
Dependent Resources
Calculating...
|
/test all |
jamengual
approved these changes
Jul 7, 2021
|
Thanks for the contribution @yariksheptykin -- we appreciate it! Released as 0.37.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #70