Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify description of db_parameter_group #67

Merged
merged 3 commits into from
Dec 28, 2020

Conversation

yariksheptykin
Copy link
Contributor

Documentation of the db_parameter_group variable is somewhat obscure with regard to possible values it intakes. It actually expects a name of DB parameter group family, which can be one of many pre-defined families provided by AWS. The list of supported families is quite hidden in AWS Documentation so I suggest placing a link to the right place stright into the variable description.

@yariksheptykin
Copy link
Contributor Author

/rebuild-readme

@yariksheptykin
Copy link
Contributor Author

/test all

2 similar comments
@yariksheptykin
Copy link
Contributor Author

/test all

@osterman
Copy link
Member

/test all

@osterman
Copy link
Member

Looks like there's an orphaned RDS instance from some previously failed test. We nuke the account every night, so will wait for that.

Error: Error creating DB Parameter Group: DBParameterGroupAlreadyExists: Parameter group eg-test-rds-test already exists
TestExamplesComplete 2020-08-20T10:55:59Z command.go:121: 	status code: 400, request id: be8fa13e-049d-4ce4-905d-67f1459441e0
TestExamplesComplete 2020-08-20T10:55:59Z command.go:121: 
TestExamplesComplete 2020-08-20T10:55:59Z command.go:121:   on ../../main.tf line 83, in resource "aws_db_parameter_group" "default":
TestExamplesComplete 2020-08-20T10:55:59Z command.go:121:   83: resource "aws_db_parameter_group" "default" {
TestExamplesComplete 2020-08-20T10:55:59Z command.go:121: 
TestExamplesComplete 2020-08-20T10:55:59Z command.go:121: 
TestExamplesComplete 2020-08-20T10:55:59Z command.go:121: 
TestExamplesComplete 2020-08-20T10:55:59Z command.go:121: Error: Error creating DB Option Group: OptionGroupAlreadyExistsFault: An option group named eg-test-rds-test already exists.
TestExamplesComplete 2020-08-20T10:55:59Z command.go:121: 	status code: 400, request id: fd03e060-94e9-4553-a518-b4cf48db75da
TestExamplesComplete 2020-08-20T10:55:59Z command.go:121: 
TestExamplesComplete 2020-08-20T10:55:59Z command.go:121:   on ../../main.tf line 99, in resource "aws_db_option_group" "default":
TestExamplesComplete 2020-08-20T10:55:59Z command.go:121:   99: resource "aws_db_option_group" "default" {
TestExamplesComplete 2020-08-20T10:55:59Z command.go:121: 
TestExamplesComplete 2020-08-20T10:55:59Z command.go:121: 
TestExamplesComplete 2020-08-20T10:55:59Z command.go:121: 
TestExamplesComplete 2020-08-20T10:55:59Z command.go:121: Error: Error creating DB Subnet Group: DBSubnetGroupAlreadyExists: The DB subnet group 'eg-test-rds-test' already exists.
TestExamplesComplete 2020-08-20T10:55:59Z command.go:121: 	status code: 400, request id: f9da063c-e676-4dd2-a1b8-aa5bea3979a1

@yariksheptykin
Copy link
Contributor Author

/test all

@yariksheptykin
Copy link
Contributor Author

/rebuild-readme

1 similar comment
@maximmi
Copy link
Contributor

maximmi commented Dec 26, 2020

/rebuild-readme

@maximmi
Copy link
Contributor

maximmi commented Dec 26, 2020

/test all

Copy link
Contributor

@maximmi maximmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yariksheptykin thanks for contribution

@maximmi maximmi merged commit ba59189 into cloudposse:master Dec 28, 2020
@yariksheptykin
Copy link
Contributor Author

@yariksheptykin thanks for contribution

Sure. Thanks for taking time to get this landed, @maximmi !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants