Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set right var type acording to readme #139

Merged
merged 2 commits into from
Jun 21, 2022
Merged

Set right var type acording to readme #139

merged 2 commits into from
Jun 21, 2022

Conversation

MaxymVlasov
Copy link
Contributor

No description provided.

@MaxymVlasov MaxymVlasov requested review from a team as code owners May 12, 2022 16:37
@Gowiem
Copy link
Member

Gowiem commented May 12, 2022

/test all

@MaxymVlasov
Copy link
Contributor Author

Error creating DB Instance: InvalidParameterCombination: Cannot find version 5.7.17 for MySQL

Looks like the test is broken

@Gowiem
Copy link
Member

Gowiem commented May 16, 2022

@MaxymVlasov Our tests seem to be currently broken. You can wait a couple weeks and ping me again when they'll likely be fixed or take a crack at fixing it yourself since it should be fairly easy. Here is the error:

Error: Error creating DB Instance: InvalidParameterCombination: Cannot find version 5.7.17 for mysql
TestExamplesComplete 2022-05-12T20:28:35Z logger.go:66: 	status code: 400, request id: 564e06e5-098d-40ae-9102-9a92b2d65484

@Gowiem Gowiem self-requested a review May 16, 2022 16:48
@nitrocode nitrocode added the no-release Do not create a new release (wait for additional code changes) label Jun 14, 2022
@nitrocode
Copy link
Member

Tests are fixed. Please merge code from the default branch to your PR branch and we can rerun the tests.

@nitrocode
Copy link
Member

/test all

@nitrocode nitrocode merged commit 1f95684 into cloudposse:master Jun 21, 2022
@MaxymVlasov MaxymVlasov deleted the patch-1 branch June 21, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

@jamengual jamengual Awaiting requested review from jamengual jamengual was automatically assigned from cloudposse/contributors

@dylanbannon dylanbannon Awaiting requested review from dylanbannon dylanbannon was automatically assigned from cloudposse/contributors

@Gowiem Gowiem Awaiting requested review from Gowiem

Assignees
No one assigned
Labels
no-release Do not create a new release (wait for additional code changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaxymVlasov @Gowiem @nitrocode