Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting ca_cert_identifier default value to null #115

Merged
merged 5 commits into from
Jun 14, 2021
Merged

Setting ca_cert_identifier default value to null #115

merged 5 commits into from
Jun 14, 2021

Conversation

nnsense
Copy link
Contributor

@nnsense nnsense commented May 23, 2021

what

Setting ca_cert_identifier default value to null, leaving its resolution up to the AWS resource.

why

Creating RDS in newer regions such as eu-south-1, ap-east-1, me-south-1, af-south-1 errors but RDS instance is still created. The default CA certificate ID (rds-ca-2019), which is valid across most of the regions, has a different format on these, see: #114 (comment)

references

@nnsense nnsense requested review from a team as code owners May 23, 2021 12:16
@nnsense nnsense requested a review from a team as a code owner May 23, 2021 12:17
@nnsense nnsense requested review from jamengual and woz5999 May 23, 2021 12:17
@Gowiem
Copy link
Member

Gowiem commented May 24, 2021

/test all

@Gowiem
Copy link
Member

Gowiem commented May 24, 2021

@nnsense thanks for the contribution as always -- it seems our got stuck which is an annoying occurrence. Mind doing the following to bump that?

git commit --allow-empty -m "Trigger CI"
git push

@nnsense
Copy link
Contributor Author

nnsense commented May 27, 2021

Hi @Gowiem is there anything else I should do?

@Gowiem
Copy link
Member

Gowiem commented Jun 14, 2021

/test all

@Gowiem Gowiem merged commit 3b6b1e8 into cloudposse:master Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants