Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform 0.13 requires snapshot_identifier explicitly set to null #106

Merged
merged 4 commits into from
Feb 26, 2021
Merged

Terraform 0.13 requires snapshot_identifier explicitly set to null #106

merged 4 commits into from
Feb 26, 2021

Conversation

nnsense
Copy link
Contributor

@nnsense nnsense commented Feb 19, 2021

what

  • With terraform 0.13 If snapshot_identifier is set to "" then the resource creation will fail ("snapshot_identifier": conflicts with username).
  • Apparently it works with >0.14 instead.

why

It seems resource "aws_db_instance" "default" defined into main changed (apparently, an hour ago?) its flexibility in taking arguments. Before (also with 0.13) defining "" was enough to use username and password for the DB. Now, I've got this:

Error: ConflictsWith                                                                                                                                                                       
                                                                                             
  on .terraform/modules/rds_instance/main.tf line 44, in resource "aws_db_instance" "default":                                                                                             
  44:   snapshot_identifier         = var.snapshot_identifier                                                                                                                              
                                                                                                                                                                                           
"snapshot_identifier": conflicts with username 

references

No references, and I might even be wrong, I rely on your testing to confirm the issue ;)

With terraform `0.13` If `snapshot_identifier` is set to "" then the resource creation will fail (`"snapshot_identifier": conflicts with username`).
Apparently it works with `>0.14` instead
@nnsense nnsense requested review from a team as code owners February 19, 2021 19:56
@nnsense nnsense requested a review from a team as a code owner February 19, 2021 19:57
Gowiem
Gowiem previously approved these changes Feb 19, 2021
@Gowiem
Copy link
Member

Gowiem commented Feb 19, 2021

/test all

runningman
runningman previously approved these changes Feb 22, 2021
@Gowiem
Copy link
Member

Gowiem commented Feb 23, 2021

@nnsense can you push an empty commit via git commit --allow-empty -m "Trigger GH Action" and then git push. We're having issues with our GH actions not triggering / reporting back status sometimes and the only way to force it is with a new commit.

Once we've got a green build then we'll get this merged. Thanks!

@mergify mergify bot dismissed Gowiem’s stale review February 26, 2021 15:50

This Pull Request has been updated, so we're dismissing all reviews.

@Gowiem
Copy link
Member

Gowiem commented Feb 26, 2021

/test all

@Gowiem Gowiem merged commit caebe2f into cloudposse:master Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants