Skip to content

Commit

Permalink
storage_encrypted default value changed to true (#92)
Browse files Browse the repository at this point in the history
  • Loading branch information
maximmi authored Jan 26, 2021
1 parent ab39f6a commit 5e99e93
Show file tree
Hide file tree
Showing 8 changed files with 564 additions and 9 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
.terraform
.idea
*.iml
**/.terraform.lock.hcl

.build-harness
build-harness
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ Available targets:
| skip\_final\_snapshot | If true (default), no snapshot will be made before deleting DB | `bool` | `true` | no |
| snapshot\_identifier | Snapshot identifier e.g: rds:production-2019-06-26-06-05. If specified, the module create cluster from the snapshot | `string` | `""` | no |
| stage | Stage, e.g. 'prod', 'staging', 'dev', OR 'source', 'build', 'test', 'deploy', 'release' | `string` | `null` | no |
| storage\_encrypted | (Optional) Specifies whether the DB instance is encrypted. The default is false if not specified | `bool` | `false` | no |
| storage\_encrypted | (Optional) Specifies whether the DB instance is encrypted. The default is false if not specified | `bool` | `true` | no |
| storage\_type | One of 'standard' (magnetic), 'gp2' (general purpose SSD), or 'io1' (provisioned IOPS SSD) | `string` | `"standard"` | no |
| subnet\_ids | List of subnets for the DB | `list(string)` | n/a | yes |
| tags | Additional tags (e.g. `map('BusinessUnit','XYZ')` | `map(string)` | `{}` | no |
Expand Down
2 changes: 1 addition & 1 deletion docs/terraform.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
| skip\_final\_snapshot | If true (default), no snapshot will be made before deleting DB | `bool` | `true` | no |
| snapshot\_identifier | Snapshot identifier e.g: rds:production-2019-06-26-06-05. If specified, the module create cluster from the snapshot | `string` | `""` | no |
| stage | Stage, e.g. 'prod', 'staging', 'dev', OR 'source', 'build', 'test', 'deploy', 'release' | `string` | `null` | no |
| storage\_encrypted | (Optional) Specifies whether the DB instance is encrypted. The default is false if not specified | `bool` | `false` | no |
| storage\_encrypted | (Optional) Specifies whether the DB instance is encrypted. The default is false if not specified | `bool` | `true` | no |
| storage\_type | One of 'standard' (magnetic), 'gp2' (general purpose SSD), or 'io1' (provisioned IOPS SSD) | `string` | `"standard"` | no |
| subnet\_ids | List of subnets for the DB | `list(string)` | n/a | yes |
| tags | Additional tags (e.g. `map('BusinessUnit','XYZ')` | `map(string)` | `{}` | no |
Expand Down
4 changes: 2 additions & 2 deletions examples/complete/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@ provider "aws" {

module "vpc" {
source = "cloudposse/vpc/aws"
version = "0.18.1"
version = "0.18.2"
context = module.this.context
cidr_block = "172.16.0.0/16"
}

module "subnets" {
source = "cloudposse/dynamic-subnets/aws"
version = "0.32.0"
version = "0.34.0"
context = module.this.context
availability_zones = var.availability_zones
vpc_id = module.vpc.vpc_id
Expand Down
2 changes: 1 addition & 1 deletion main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ resource "aws_security_group_rule" "egress" {

module "dns_host_name" {
source = "cloudposse/route53-cluster-hostname/aws"
version = "0.9.0"
version = "0.10.0"
enabled = length(var.dns_zone_id) > 0 && module.this.enabled
dns_name = var.host_name
zone_id = var.dns_zone_id
Expand Down
5 changes: 2 additions & 3 deletions test/src/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,9 @@ go 1.14

require (
github.com/aws/aws-sdk-go v1.36.9 // indirect
github.com/davecgh/go-spew v1.1.1 // indirect
github.com/go-sql-driver/mysql v1.5.0 // indirect
github.com/google/uuid v1.1.2 // indirect
github.com/gruntwork-io/terratest v0.16.0
github.com/gruntwork-io/terratest v0.31.3
github.com/pquerna/otp v1.3.0 // indirect
github.com/stretchr/testify v1.3.0
github.com/stretchr/testify v1.4.0
)
555 changes: 555 additions & 0 deletions test/src/go.sum

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ variable "storage_type" {
variable "storage_encrypted" {
type = bool
description = "(Optional) Specifies whether the DB instance is encrypted. The default is false if not specified"
default = false
default = true
}

variable "iops" {
Expand Down

0 comments on commit 5e99e93

Please sign in to comment.