Feat: Context tags for subnets and routetables #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brad-haynes
requested review from
r351574nc3 and
Benbentwo
and removed request for
a team
Gowiem
previously requested changes
Feb 25, 2022
There was a problem hiding this comment.
@brad-haynes this is good stuff -- Thanks for adding it. One request, but otherwise we'll get this merged.
private.tf
Outdated
| @@ -18,7 +18,7 @@ resource "aws_subnet" "private" { | |||
| cidr_block = cidrsubnet(var.cidr_block, ceil(log(var.max_subnets, 2)), count.index) | |||
| map_public_ip_on_launch = var.map_public_ip_on_launch_enabled | |||
|
|
|||
| tags = merge({ | |||
| tags = merge(module.private_label.tags, { | |||
| "Name" = "${module.private_label.id}${module.this.delimiter}${element(var.subnet_names, count.index)}" | |||
| "Stage" = module.private_label.stage | |||
There was a problem hiding this comment.
Can you remove the Stage + Namespace entries from the override map? They're unnecessary now that we're using the top level tags as the base map. Please remove them from all of the instances that you've updated.
There was a problem hiding this comment.
I was actually just doing that.
mergify
bot
dismissed
Gowiem’s stale review
This Pull Request has been updated, so we're dismissing all reviews.
|
/test all |
|
@brad-haynes Thanks for the contribution! Released as https://github.com/cloudposse/terraform-aws-named-subnets/releases/tag/0.12.0 |
|
Thanks, @Gowiem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
references