Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and update variables and inputs #90

Merged
merged 3 commits into from
May 17, 2023
Merged

Fix and update variables and inputs #90

merged 3 commits into from
May 17, 2023

Conversation

aknysh
Copy link
Member

@aknysh aknysh commented May 17, 2023

what

  • Fix and update variables and inputs
  • Bump Go to 1.20 in terratest

why

  • Remove unused (deprecated) variables
  • Use all the variables that are declared
  • Add missing outputs
  • Fix output types and descriptions
  • Fix the tflint errors:
WARNING: "tflint FILE/DIR" is deprecated and will error in a future version. Use --chdir or --filter instead.
  reviewdog: input data has violations
  security-group-variables.tf:146:1: warning: variable "allow_all_egress" is declared but not used ()
  security-group-variables.tf:202:1: warning: variable "inline_rules_enabled" is declared but not used ()
  security-group-variables.tf:212:1: warning: variable "revoke_security_group_rules_on_delete" is declared but not used ()
  security-group-variables.tf:[66](https://github.com/cloudposse/terraform-aws-msk-apache-kafka-cluster/actions/runs/5006279988/jobs/8971794698#step:6:74):1: warning: variable "allowed_ipv6_cidr_blocks" is declared but not used ()
  security-group-variables.tf:75:1: warning: variable "allowed_ipv6_prefix_list_ids" is declared but not used ()
  variables-deprecated.tf:1:1: warning: variable "security_groups" is declared but not used ()

@aknysh aknysh added the minor New features that do not break anything label May 17, 2023
@aknysh aknysh self-assigned this May 17, 2023
@aknysh aknysh requested review from a team as code owners May 17, 2023 19:24
@aknysh aknysh requested review from dotCipher and joe-niland May 17, 2023 19:24
@aknysh
Copy link
Member Author

aknysh commented May 17, 2023

/terratest

@aknysh
Copy link
Member Author

aknysh commented May 17, 2023

/terratest

@aknysh
Copy link
Member Author

aknysh commented May 17, 2023

/terratest

@aknysh aknysh merged commit 1a63c04 into main May 17, 2023
@aknysh aknysh deleted the fix-vars branch May 17, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor New features that do not break anything
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants