Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users manage own access keys #10

Merged
merged 11 commits into from
Dec 26, 2018
Merged

Allow users manage own access keys #10

merged 11 commits into from
Dec 26, 2018

Conversation

goruha
Copy link
Member

@goruha goruha commented Dec 19, 2018

What

  • Allow users to manage own access keys

Why

  • If they can manage passwords, they should be able to manage access keys

@goruha goruha requested a review from aknysh December 19, 2018 16:10
@goruha goruha requested a review from osterman December 19, 2018 16:10
@osterman
Copy link
Member

Fix CI

osterman
osterman reviewed Dec 19, 2018
View reviewed changes
main.tf Outdated Show resolved Hide resolved
osterman
osterman reviewed Dec 19, 2018
View reviewed changes
main.tf Outdated Show resolved Hide resolved
osterman
osterman reviewed Dec 19, 2018
View reviewed changes
main.tf Outdated Show resolved Hide resolved
osterman
osterman reviewed Dec 19, 2018
View reviewed changes
main.tf Outdated Show resolved Hide resolved
osterman
osterman reviewed Dec 19, 2018
View reviewed changes
main.tf Outdated Show resolved Hide resolved
osterman
osterman reviewed Dec 19, 2018
View reviewed changes
main.tf Outdated Show resolved Hide resolved
@osterman
Copy link
Member

Fix CI

osterman
osterman requested changes Dec 21, 2018
View reviewed changes
Copy link
Member

@osterman osterman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They can already do this, pretty sure. They just need to assume role first. They should not be able to create any access keys without MFA. The changes in this PR don't seem to require MFA. The password stuff was done (without MFA) so they can self-register after receiving an invitation link. The same is not true for keys.

@goruha
Copy link
Member Author

goruha commented Dec 22, 2018 •
edited
Loading

They can already do this, pretty sure.

Nope. Only admin roles can manage the keys.

They just need to assume role first.

Assume role - readonly allow only to read, not to renew or create another one.

They should not be able to create any access keys without MFA.

Done.

The changes in this PR don't seem to require MFA.

Done

The password stuff was done (without MFA) so they can self-register after receiving an invitation link. > > The same is not true for keys.

Done

@goruha goruha assigned osterman and unassigned osterman Dec 22, 2018
@goruha goruha merged commit c810a48 into master Dec 26, 2018
@goruha goruha deleted the feature/cp-100/allow-users-manage-own-keys branch December 26, 2018 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@osterman osterman osterman approved these changes

Assignees

@osterman osterman

@goruha goruha

@aknysh aknysh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goruha @osterman @aknysh