Added AutoTune support

[dm3ch]

what

• Add support for AutoTune

why

• Provide support of AutoTune feature

references

• closes No support for autotune #121

[goruha]

/test all

[goruha]

@dm3ch
pls add here the default value; otherwise, this is a required variable.

[dm3ch]

These values are not used by default (if auto_tune_enabled = false), so requiring them is not a best option.
And there's no default value in provider as far as I remember.

So I see 2 possible options how it can be done:

• Add some default value, which we would think optimal
• Try to add a validation rule that would check if auto_tune_enabled = true and require variable in this case

What do you think would be better?

[dm3ch]

As far as I remember validation condition can't refer to other vars, so the second option is impossible. :(

So to be honest I don't know how to better workaround this. Do you have any thoughts?

[goruha]

@dm3ch
pls add here the default value; otherwise, this is a required variable.

[goruha]

/test all

[dm3ch]

@goruha Reworked input variable for auto tune to an object to be able to validate values if auto tune is enabled to not add default values (cause provider doesn't have default values for that).

Could you please re-review?

[goruha]

/test all

[goruha]

@dm3ch

tests still failed

First reason - terraform lint

not ok 8 check if terraform code is valid
# (from function `setup' in test file test/.test-harness/test/terraform/validate.bats, line 7)
#   `terraform init >/dev/null' failed
# There are some problems with the configuration, described below.
#
# The Terraform configuration must be valid before initialization so that
# Terraform can determine which modules and providers need to be installed.
# 
# Error: Invalid reference in variable validation
#
#   on variables.tf line 394, in variable "auto_tune":
#  394:     condition     = var.auto_tune.enabled == true && var.cron_schedule != null
# 
# The condition for variable "auto_tune" can only refer to the variable itself,
# using var.auto_tune.
# 
# 
# Error: Invalid validation error message
#
#   on variables.tf line [39](https://github.com/cloudposse/actions/actions/runs/4203523341/jobs/7293033803#step:8:40)5, in variable "auto_tune":
#  395:     error_message = "var.auto_tune.cron_schedule should be set if var.auto_tune.enabled == true"
# 
# Validation error message must be at least one full English sentence starting
# with an uppercase letter and ending with a period or question mark.
# 
# 
# Error: Invalid reference in variable validation
#
#   on variables.tf line 399, in variable "auto_tune":
#  399:     condition     = var.auto_tune.enabled == true && var.duration != null
# 
# The condition for variable "auto_tune" can only refer to the variable itself,
# using var.auto_tune.
# 
# 
# Error: Invalid validation error message
#
#   on variables.tf line [40](https://github.com/cloudposse/actions/actions/runs/4203523341/jobs/7293033803#step:8:41)0, in variable "auto_tune":
#  400:     error_message = "var.auto_tune.duration should be set if var.auto_tune.enabled == true"
# 
# Validation error message must be at least one full English sentence starting
# with an uppercase letter and ending with a period or question mark.
# 
# 
# Error: Invalid validation error message
#
#   on variables.tf line 405, in variable "auto_tune":
#  405:     error_message = "var.auto_tune.rollback_on_disable valid values: DEFAULT_ROLLBACK or NO_ROLLBACK."
# 
# Validation error message must be at least one full English sentence starting
# with an uppercase letter and ending with a period or question mark.
#

The second reason - is, please, rebase the latest changes from the master branch - it looks like you lost it when did there rewrite

[dm3ch]

Seems to be done. But haven't try to run terraform lint locally

[goruha]

/test all

[goruha]

@dm3ch

Tests failed

Test: check if terraform code is valid
File: validate.bats
---------------------------------

Error: Invalid value for variable

  on ../../variables.tf line 367:
 367: variable "auto_tune" {

Variable auto_tune.cron_schedule should be set if var.auto_tune.enabled ==
true.

This was checked by the validation rule at ../../variables.tf:393,3-13.


Error: Invalid value for variable

  on ../../variables.tf line 367:
 367: variable "auto_tune" {

Variable auto_tune.duration should be set if var.auto_tune.enabled == true.

This was checked by the validation rule at ../../variables.tf:398,3-13.

Gime 5 minutes I will suggest fixes

[goruha]

@dm3ch check my suggestions

[dm3ch]

@goruha Yep, TY, missed it.

[dm3ch]

One more tests run?

Let's hope it would be final.

[goruha]

/test all

[goruha]

@dm3ch LGTM