Skip to content

feat: Add support for aws provider 5.0 #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 30, 2023
Merged

feat: Add support for aws provider 5.0 #198

merged 3 commits into from
May 30, 2023

Conversation

MaxymVlasov
Copy link
Contributor

@MaxymVlasov MaxymVlasov commented May 29, 2023 •
edited
Loading

why

That field was deprecated in 4.0 and was removed in 5.0

Note:

make init
make github/init
make readme

Already ran and committed

@MaxymVlasov MaxymVlasov requested review from a team as code owners May 29, 2023 14:50
@aknysh
Copy link
Member

aknysh commented May 29, 2023

/terratest

@aknysh
Copy link
Member

aknysh commented May 29, 2023

@MaxymVlasov unfortunately, this one needs more work in the examples https://github.com/cloudposse/actions/actions/runs/5113075572/jobs/9191868981

vpc module needs to be updated first

1 similar comment
@aknysh
Copy link
Member

aknysh commented May 29, 2023

@MaxymVlasov unfortunately, this one needs more work in the examples https://github.com/cloudposse/actions/actions/runs/5113075572/jobs/9191868981

vpc module needs to be updated first

@aknysh
Copy link
Member

aknysh commented May 29, 2023

/terratest

@aknysh
Copy link
Member

aknysh commented May 29, 2023

/terratest

aknysh
aknysh reviewed May 29, 2023
View reviewed changes
aknysh
aknysh reviewed May 29, 2023
View reviewed changes
aknysh
aknysh requested changes May 29, 2023
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments

@MaxymVlasov @aknysh
Apply suggestions from code review
4098f0d 
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
@MaxymVlasov MaxymVlasov requested a review from aknysh May 29, 2023 17:21
@aknysh
Copy link
Member

aknysh commented May 30, 2023

/terratest

@aknysh aknysh added the patch A minor, backward compatible change label May 30, 2023
aknysh
aknysh approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @MaxymVlasov

@aknysh aknysh merged commit 6d2fef2 into cloudposse:main May 30, 2023
@MaxymVlasov MaxymVlasov deleted the aws_5.0 branch May 30, 2023 14:15
This was referenced Jul 18, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aknysh aknysh aknysh approved these changes

@srhopkins srhopkins Awaiting requested review from srhopkins srhopkins is a code owner automatically assigned from cloudposse/contributors

@korenyoni korenyoni Awaiting requested review from korenyoni korenyoni is a code owner automatically assigned from cloudposse/contributors

Assignees

No one assigned

Labels

patch A minor, backward compatible change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MaxymVlasov @aknysh