Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bc cmpliance #52

Merged
merged 3 commits into from
Jan 19, 2021
Merged

Bc cmpliance #52

merged 3 commits into from
Jan 19, 2021

Conversation

maximmi
Copy link
Contributor

@maximmi maximmi commented Jan 18, 2021

what

  • BridgeCrew compliance checks fix
  • readme updated
  • Terraform code formatting

why

  • To be able to position our modules as standards compliant
  • Providing explicit note about policy attached directly to user
  • To stick to canonical format and style

references

@maximmi maximmi requested a review from osterman January 18, 2021 10:07
@maximmi maximmi requested review from a team as code owners January 18, 2021 10:07
@maximmi maximmi requested review from Gowiem and removed request for a team January 18, 2021 10:07
@maximmi
Copy link
Contributor Author

maximmi commented Jan 18, 2021

/test all

@maximmi
Copy link
Contributor Author

maximmi commented Jan 18, 2021

/terrraform-fmt

@Nuru
Copy link
Contributor

Nuru commented Jan 19, 2021

/terraform-fmt

Nuru
Nuru previously approved these changes Jan 19, 2021
View reviewed changes
@Nuru
Copy link
Contributor

Nuru commented Jan 19, 2021

/terraform-fmt

@Nuru
Copy link
Contributor

Nuru commented Jan 19, 2021

/test all

@Nuru Nuru self-requested a review January 19, 2021 06:03
@Nuru Nuru merged commit a3dc24f into master Jan 19, 2021
@Nuru Nuru deleted the bc-cmpliance branch January 19, 2021 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nuru Nuru Nuru approved these changes

@osterman osterman Awaiting requested review from osterman

@Gowiem Gowiem Awaiting requested review from Gowiem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maximmi @Nuru @actions-bot