Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add capacity_type to support node group spot pricing #45

Merged
merged 4 commits into from
Dec 4, 2020
Merged

Add capacity_type to support node group spot pricing #45

merged 4 commits into from
Dec 4, 2020

Conversation

ChrisMcKee
Copy link
Contributor

@ChrisMcKee ChrisMcKee commented Dec 4, 2020 •
edited
Loading

@ChrisMcKee ChrisMcKee requested review from a team as code owners December 4, 2020 16:22
@ChrisMcKee ChrisMcKee requested review from Gowiem and SweetOps and removed request for a team December 4, 2020 16:22
@ChrisMcKee
Copy link
Contributor Author

image
Tested working.

@Gowiem
Copy link
Member

Gowiem commented Dec 4, 2020

/test all

@Gowiem
Copy link
Member

Gowiem commented Dec 4, 2020

/rebuild-readme

@ChrisMcKee
Copy link
Contributor Author

one day the readme gods will look kindly on me 😆

@Gowiem
Copy link
Member

Gowiem commented Dec 4, 2020

/test all

Gowiem
Gowiem requested changes Dec 4, 2020
View reviewed changes
.gitattributes Show resolved Hide resolved
@Gowiem
Copy link
Member

Gowiem commented Dec 4, 2020

@ChrisMcKee the README god is real a PITA - don't take it personally 😉

I forgot that out terratests are currently broken. It's a permissioning issue and should be fixed soon I believe. We'll need to get those fixed and green before we can get this merged. Sorry for the hold up!

@ChrisMcKee
Update .gitattributes
7ce732e 
Remove other entries as wildcard will cover it
@ChrisMcKee ChrisMcKee requested review from Gowiem and removed request for a team December 4, 2020 17:50
@ChrisMcKee
Copy link
Contributor Author

Accidentally removed engineering (not sure how 😬 ) fat fingered the tab

Gowiem
Gowiem previously approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid, we'll get this merged once terratests get fixed. 👍

@Gowiem
Copy link
Member

Gowiem commented Dec 4, 2020

/test all

@Gowiem Gowiem added the terraform/0.13 Module requires Terraform 0.13 or later label Dec 4, 2020
@Gowiem
Copy link
Member

Gowiem commented Dec 4, 2020

/test all

@Gowiem
Copy link
Member

Gowiem commented Dec 4, 2020

/terraform-fmt

@Gowiem
Copy link
Member

Gowiem commented Dec 4, 2020

/test all

Gowiem
Gowiem approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gowiem Gowiem changed the title Add capacity_type to support managed worker node group spot pricing Add capacity_type to support node group spot pricing Dec 4, 2020
@Gowiem Gowiem merged commit bd9d419 into cloudposse:master Dec 4, 2020
@ChrisMcKee
Copy link
Contributor Author

Thanks 👍

@patrickjahns patrickjahns mentioned this pull request Jan 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gowiem Gowiem Gowiem approved these changes

@SweetOps SweetOps Awaiting requested review from SweetOps

Assignees
No one assigned
Labels
terraform/0.13 Module requires Terraform 0.13 or later
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrisMcKee @Gowiem @actions-bot