Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add disk options for ec2 template #44

Merged
merged 1 commit into from
Dec 18, 2020
Merged

add disk options for ec2 template #44

merged 1 commit into from
Dec 18, 2020

Conversation

dmitriy-lukyanchikov
Copy link
Contributor

what

  • add options to define volume_type and km key for volume

why

  • its obvious that sometimes we need to define it

@dmitriy-lukyanchikov dmitriy-lukyanchikov requested review from jamengual and danjbh and removed request for a team November 30, 2020 21:06
@dmitriy-lukyanchikov
Copy link
Contributor Author

@aknysh please review this one

@Gowiem
Copy link
Member

Gowiem commented Dec 4, 2020

/test all

@Gowiem Gowiem self-requested a review December 4, 2020 23:24
@Gowiem Gowiem added the terraform/0.13 Module requires Terraform 0.13 or later label Dec 6, 2020
@Gowiem
Copy link
Member

Gowiem commented Dec 6, 2020

/test all

@Nuru Nuru added the patch A minor, backward compatible change label Dec 18, 2020
@Nuru Nuru merged commit e3c254e into cloudposse:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nuru Nuru Nuru approved these changes

@jamengual jamengual Awaiting requested review from jamengual

@danjbh danjbh Awaiting requested review from danjbh

@Gowiem Gowiem Awaiting requested review from Gowiem

Assignees
No one assigned
Labels
patch A minor, backward compatible change terraform/0.13 Module requires Terraform 0.13 or later
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmitriy-lukyanchikov @Gowiem @Nuru