Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow ebs launch template encryption #36

Merged
merged 7 commits into from
Oct 14, 2020
Merged

feat: allow ebs launch template encryption #36

merged 7 commits into from
Oct 14, 2020

Conversation

dotCipher
Copy link
Contributor

what

  • Surface variable for boolean flag of launch_template_disk_encryption
  • Use launch_template_disk_encryption to flip flag of generated launch_template.ebs.encryption

why

  • Allow EBS encryption

references

@dotCipher dotCipher requested review from a team as code owners October 8, 2020 20:33
@dotCipher dotCipher requested review from jhosteny and nitrocode and removed request for a team October 8, 2020 20:33
@Gowiem
Copy link
Member

Gowiem commented Oct 13, 2020

/rebuild-readme

@Gowiem
Copy link
Member

Gowiem commented Oct 13, 2020

/test all

@aknysh aknysh added the terraform/0.13 Module requires Terraform 0.13 or later label Oct 13, 2020
@Gowiem
Copy link
Member

Gowiem commented Oct 13, 2020

/test all

@Gowiem Gowiem added the enhancement New feature or request label Oct 13, 2020
@Gowiem
Copy link
Member

Gowiem commented Oct 13, 2020

/terraform-fmt

@Gowiem
Copy link
Member

Gowiem commented Oct 13, 2020

/test all

aknysh
aknysh reviewed Oct 13, 2020
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Oct 13, 2020
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Oct 13, 2020
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

dotCipher and others added 2 commits October 13, 2020 18:18
@dotCipher @aknysh
Update variables.tf
ca376b6 
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
@dotCipher @aknysh
Update variables.tf
c62d0de 
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
@dotCipher
Copy link
Contributor Author

Cool, thanks for the review!

@dotCipher dotCipher requested a review from aknysh October 14, 2020 00:46
@aknysh
Copy link
Member

aknysh commented Oct 14, 2020

/rebuild-readme

@aknysh
Copy link
Member

aknysh commented Oct 14, 2020

/terraform-fmt

@aknysh
Copy link
Member

aknysh commented Oct 14, 2020

/test all

aknysh
aknysh reviewed Oct 14, 2020
View reviewed changes
launch-template.tf Outdated Show resolved Hide resolved
aknysh
aknysh requested changes Oct 14, 2020
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments

@dotCipher @aknysh
Update launch-template.tf
3839474 
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
@dotCipher
Copy link
Contributor Author

/rebuild-readme

@dotCipher dotCipher requested a review from aknysh October 14, 2020 01:19
@aknysh
Copy link
Member

aknysh commented Oct 14, 2020

/rebuild-readme

@aknysh
Copy link
Member

aknysh commented Oct 14, 2020

/test all

aknysh
aknysh approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @dotCipher

@aknysh aknysh merged commit 836ca1d into cloudposse:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@jhosteny jhosteny Awaiting requested review from jhosteny

@nitrocode nitrocode Awaiting requested review from nitrocode

Assignees
No one assigned
Labels
enhancement New feature or request terraform/0.13 Module requires Terraform 0.13 or later
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EBS Node Encryption
4 participants
@dotCipher @Gowiem @aknysh @actions-bot