Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More triggers for replacement, better handling of enabled=false #32

Merged
merged 2 commits into from
Sep 8, 2020

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Sep 8, 2020

what

  • Fix edge cases where certain inputs would cause errors when the module enabled = false
  • Make cluster name dependent on additional variables so that it changes whenever the node group needs to be replaced

why

  • Module should always work (and create no resources) when var.enabled = false as long as other variables are valid
  • Terraform will fail when create_before_destroy is set if it needs to replace the node group but the name does not change

@Nuru Nuru added terraform/0.13 Module requires Terraform 0.13 or later bugfix Change that restores intended behavior labels Sep 8, 2020
@Nuru Nuru requested review from a team as code owners September 8, 2020 00:24
@Nuru Nuru requested review from jhosteny and joe-niland and removed request for a team September 8, 2020 00:24
@Nuru
Copy link
Contributor Author

Nuru commented Sep 8, 2020

/test all

@Nuru Nuru requested review from aknysh and removed request for jhosteny and joe-niland September 8, 2020 00:29
@Nuru
Copy link
Contributor Author

Nuru commented Sep 8, 2020

/test all

@Nuru Nuru merged commit a93cdea into master Sep 8, 2020
@Nuru Nuru deleted the enabled branch September 8, 2020 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Change that restores intended behavior terraform/0.13 Module requires Terraform 0.13 or later
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants