Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional variable to transmit "depends_on" dependency #15

Merged
merged 1 commit into from
May 1, 2020

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Apr 30, 2020

what

  • Add module_depends_on variable to allow user to force this module to wait for the creation of an arbitrary resource before creating the node group

why

  • Terraform has a depends_on feature, but it is not supported for modules and support is not likely to be added. This provides equivalent functionality, and is useful for the situation where you want to operate on a newly created cluster before creating node groups.

@Nuru Nuru requested a review from a team as a code owner April 30, 2020 20:55
@maximmi
Copy link
Contributor

maximmi commented Apr 30, 2020

/codefresh run test

@osterman osterman merged commit e248c50 into master May 1, 2020
@aknysh aknysh deleted the depends branch May 17, 2020 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants