Add missing managed AMI codes #137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitrocode
reviewed
Dec 23, 2022
|
Please fill out the full PR template |
nitrocode
reviewed
Dec 23, 2022
| @@ -111,14 +111,14 @@ variable "ami_type" { | |||
| type = string | |||
| description = <<-EOT | |||
| Type of Amazon Machine Image (AMI) associated with the EKS Node Group. | |||
There was a problem hiding this comment.
Have you tested this change?
I think you may need more changes to this file
terraform-aws-eks-node-group/ami.tf
Line 4 in ea8401e
There was a problem hiding this comment.
Indeed I missed the file.
I not tested properly, I was in rush working locally with quick tricks to make my need work.
I will take a look better, thanks for catching that!
Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what