Skip to content

Updating modules dependencies, to add the fix for github provider #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jun 19, 2020
Merged

Updating modules dependencies, to add the fix for github provider #33

merged 13 commits into from
Jun 19, 2020

Conversation

jamengual
Copy link
Contributor

@jamengual jamengual commented May 22, 2020 •
edited
Loading

Adding the fix for the webhook module and updating codebuild module

@aknysh
Copy link
Member

aknysh commented May 22, 2020

/codefresh run test

@aknysh
Copy link
Member

aknysh commented May 22, 2020

@jamengual thanks for the PR
something is wrong with the github provider:

TestExamplesComplete 2020-05-22T15:52:48Z command.go:121:                                                                                                                                
TestExamplesComplete 2020-05-22T15:52:48Z command.go:121: Error: GET https://api.github.com/orgs/cloudposse: 401 Bad credentials []                                                      
TestExamplesComplete 2020-05-22T15:52:48Z command.go:121:                                                                                                                                
TestExamplesComplete 2020-05-22T15:52:48Z command.go:121:   on /codefresh/volume/terraform-aws-ecs-codepipeline/test/src/.terraform/modules/ecs_codepipeline.github_webhooks/main.tf line
 1, in provider "github":                                                                                                                                                                
TestExamplesComplete 2020-05-22T15:52:48Z command.go:121:    1: provider "github" {                                                                                                      
TestExamplesComplete 2020-05-22T15:52:48Z command.go:121:                                                                                                                                
TestExamplesComplete 2020-05-22T15:52:48Z command.go:121:                                                                                                                                
TestExamplesComplete 2020-05-22T15:52:48Z retry.go:80: Returning due to fatal error: FatalError{Underlying: exit status 1}

the testa are failing, we need to take a look at this

@osterman osterman requested a review from aknysh June 1, 2020 23:34
@osterman
Copy link
Member

/test all

1 similar comment
@jamengual
Copy link
Contributor Author

/test all

osterman
osterman reviewed Jun 10, 2020
View reviewed changes
@osterman
Copy link
Member

/test all

@jamengual
Copy link
Contributor Author

jamengual commented Jun 11, 2020 •
edited
Loading

we still have the authentication problem, I wonder if it is a provider inheritance problem

@jamengual
Copy link
Contributor Author

/test all

@osterman
Copy link
Member

/test terratest

1 similar comment
@osterman
Copy link
Member

/test terratest

@osterman
Copy link
Member

/test all

1 similar comment
@jamengual
Copy link
Contributor Author

/test all

@jamengual
Copy link
Contributor Author

/test all

@jamengual
Copy link
Contributor Author

/test all

1 similar comment
@jamengual
Copy link
Contributor Author

/test all

@jamengual
Copy link
Contributor Author

/test all

@jamengual
Copy link
Contributor Author

/test all

@jamengual jamengual requested review from a team and RothAndrew and removed request for a team June 19, 2020 21:08
osterman
osterman previously approved these changes Jun 19, 2020
View reviewed changes
Gowiem
Gowiem requested changes Jun 19, 2020
View reviewed changes
variables.tf Outdated
variable "cache_type" {
type = string
default = "S3"
description = "The type of storage that will be used for the AWS CodeBuild project cache. Valid values: NO_CACHE, LOCAL, and S3. Defaults to NO_CACHE. If cache_type is S3, it will create an S3 bucket for storing codebuild cache inside"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamengual Your description say "Defaults to NO_CACHE.", but the default in the variable is "S3". Wanna update it to "NO_CACHE"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@jamengual
Copy link
Contributor Author

/test all

Gowiem
Gowiem approved these changes Jun 19, 2020
View reviewed changes
Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Gowiem
Copy link
Member

Gowiem commented Jun 19, 2020

/test all

@jamengual jamengual merged commit e9695c1 into cloudposse:master Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gowiem Gowiem Gowiem approved these changes

@osterman osterman osterman left review comments

@aknysh aknysh Awaiting requested review from aknysh

@RothAndrew RothAndrew Awaiting requested review from RothAndrew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamengual @aknysh @osterman @Gowiem