Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add response headers policy input for CloudFront distributions default behaviour #76

Merged

Conversation

itschrishudson
Copy link
Contributor

what

  • Adds an input to pass a response headers policy ID into the CloudFront distribution in the default cache behaviour.

why

  • AWS have recently released the ability to generate response header policies to add response headers for CORS/Security and custom use cases instead of setting at the origin or using a Lambda.
  • The current module does not allow you to pass in the ID of a policy in order to associate it with a the CloudFront distributions default behaviour.

references

@nitrocode
Copy link
Member

/test all

Copy link
Member

@nitrocode nitrocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved and merged cloudposse/terraform-aws-cloudfront-s3-cdn#195 and this is a duplicate PR for this module.

@nitrocode nitrocode merged commit 9fb2262 into cloudposse:master Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants