Skip to content

feat: Add throttling variables #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 13, 2025
Merged

feat: Add throttling variables #58

merged 2 commits into from
Mar 13, 2025

Conversation

@pablotp
Copy link
Contributor

@pablotp pablotp commented Mar 13, 2025 •
edited
Loading

what

why

  • To allow configuring the Rate and Burst limits for the stage. See:
Screenshot 2025-03-13 at 11 17 12
  • If this change is accepted, I plan to add those variables to the Atmos component too.

references

@mergify mergify bot added the triage Needs triage label Mar 13, 2025
@pablotp pablotp marked this pull request as ready for review March 13, 2025 10:18
@pablotp pablotp requested review from a team as code owners March 13, 2025 10:18
This was referenced Mar 13, 2025
Closed
Merged
@RoseSecurity
Copy link
Contributor

RoseSecurity commented Mar 13, 2025

/terratest

@RoseSecurity
Copy link
Contributor

RoseSecurity commented Mar 13, 2025

@pablotp Could you please run a terraform fmt on the code and commit the formatted version? Our pipeline is failing due to formatting issues.

@RoseSecurity
Copy link
Contributor

RoseSecurity commented Mar 13, 2025

/terratest

RoseSecurity
RoseSecurity approved these changes Mar 13, 2025
View reviewed changes
Copy link
Contributor

@RoseSecurity RoseSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

@RoseSecurity RoseSecurity merged commit b922919 into cloudposse:main Mar 13, 2025
18 checks passed
@RoseSecurity RoseSecurity added enhancement New feature or request minor New features that do not break anything labels Mar 13, 2025
@mergify mergify bot removed the triage Needs triage label Mar 13, 2025
@RoseSecurity RoseSecurity removed enhancement New feature or request minor New features that do not break anything labels Mar 13, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2025

These changes were released in v0.8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RoseSecurity RoseSecurity RoseSecurity approved these changes

@johncblandii johncblandii Awaiting requested review from johncblandii johncblandii is a code owner automatically assigned from cloudposse/contributors

@gberenice gberenice Awaiting requested review from gberenice gberenice is a code owner automatically assigned from cloudposse/contributors

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pablotp @RoseSecurity