Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Sep 6, 2023

Mend Renovate

This PR contains the following updates:

Package Type Update Change
cloudposse/cloudwatch-logs/aws (source) module patch 0.6.5 -> 0.6.8

Release Notes

cloudposse/terraform-aws-cloudwatch-logs (cloudposse/cloudwatch-logs/aws)

v0.6.8

Compare Source

🚀 Enhancements

Fix mistake in policy. Part2 @​ramses999 (#​39)

what

This is just a continuation of the fix https://github.com/cloudposse/terraform-aws-cloudwatch-logs/pull/38.
Prod environment tested. That's how it works correctly.

v0.6.7

Compare Source

🚀 Enhancements

Fix mistake in policy @​ramses999 (#​38)

what

Fix mistake in policy

why

The policy is created simply by ARN without the ":" construct, which is necessary to create the correct policy for the role.
Without this ":" construct, the policy is created, but it does not work correctly.
This error was discovered when I tried to create a cloudwatch group in the cloudtrail module.
I got the response "Error: Error updating CloudTrail: InvalidCloudWatchLogsLogGroupArnException: Access denied. Verify in IAM that the role has adequate permissions."
After studying the code, I realized that I need to add the construction ":*" in a couple of lines.
My solution looks like this, I need to replace the lines in file :

This line:
join("", aws_cloudwatch_log_group.default..arn),
replaced by
"${join("", aws_cloudwatch_log_group.default.
.arn)}:*"
You need to do this in both identical lines.

Perhaps you can suggest a better solution, I'm new to terraforming.

references

https://github.com/cloudposse/terraform-aws-cloudwatch-logs/issues/37
https://github.com/cloudposse/terraform-aws-cloudwatch-logs/blob/master/iam.tf#L55

v0.6.6

Compare Source

🤖 Automatic Updates

Update Terraform cloudposse/iam-role/aws to v0.16.2 @​renovate (#​33)

This PR contains the following updates:

Package Type Update Change
cloudposse/iam-role/aws (source) module patch 0.16.1 -> 0.16.2


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested review from a team as code owners September 6, 2023 05:43
@renovate renovate bot added the auto-update This PR was automatically generated label Sep 6, 2023
@renovate renovate bot requested review from johncblandii and nitrocode September 6, 2023 05:43
@renovate
Copy link
Contributor Author

renovate bot commented Sep 7, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@max-lobur max-lobur added the minor New features that do not break anything label Sep 12, 2023
@max-lobur
Copy link
Contributor

/terratest

@max-lobur max-lobur enabled auto-merge (squash) September 12, 2023 12:06
@max-lobur max-lobur merged commit 122375a into main Sep 12, 2023
@max-lobur max-lobur deleted the renovate/main-cloudposse-cloudwatch-logs-aws-0.x branch September 12, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-update This PR was automatically generated minor New features that do not break anything

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants