Skip to content

Conversation

@ByJacob
Copy link
Contributor

@ByJacob ByJacob commented May 28, 2023

what

  • add relations between aws_api_gateway_deployment and aws_api_gateway_rest_api_policy

why

╷
│ Error: creating API Gateway Deployment: BadRequestException: Private REST API doesn't have a resource policy attached to it
│ 
│   with module.api_gwt.aws_api_gateway_deployment.this[0],
│   on ../../modules/api-gwt/main.tf line 39, in resource "aws_api_gateway_deployment" "this":
│   39: resource "aws_api_gateway_deployment" "this" {
│ 
╵

references

@ByJacob ByJacob requested review from a team as code owners May 28, 2023 10:15
@ByJacob ByJacob requested review from korenyoni and srhopkins May 28, 2023 10:15
jamengual
jamengual previously approved these changes Aug 28, 2023
@jamengual
Copy link
Contributor

/terratest

@max-lobur max-lobur added the minor New features that do not break anything label Sep 1, 2023
max-lobur
max-lobur previously approved these changes Sep 4, 2023
@jamengual
Copy link
Contributor

please run make precommit/terraform and commit the changes.

Thanks.

@jamengual jamengual dismissed stale reviews from max-lobur and themself via b0b4b58 September 6, 2023 05:58
@jamengual
Copy link
Contributor

/terratest

@max-lobur
Copy link
Contributor

Still needs make precommit/terraform

@max-lobur
Copy link
Contributor

Checking why that readme change did not show up on a scheduled readme build. It's not coming from a PR, it's a template change from few months ago.

@max-lobur
Copy link
Contributor

/terratest

@max-lobur max-lobur enabled auto-merge (squash) September 12, 2023 12:13
@max-lobur
Copy link
Contributor

Should be good now, this just needed a rebase.

@max-lobur max-lobur merged commit 54d5799 into cloudposse:main Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor New features that do not break anything

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants