Skip to content

incorrect log-group role principal #35

@dougbergh

Description

@dougbergh

Describe the Bug

The module creates a log-group role with principal service "ec2.amazonaws.com". The api-gateway is then unable to be created.

The principal service should be "apigateway.amazonaws.com"

Expected Behavior

The log group role should be created with principal service "apigateway.amazonaws.com"

Steps to Reproduce

create an api-gateway in AWS using the module

Screenshots

No response

Environment

No response

Additional Context

In a SweetOps exchange with Andriy Knysh, he suggested the following:

this is an omission here: https://github.com/cloudposse/terraform-aws-api-gateway/blob/main/main.tf#L28. The variable principals needs to be added since the https://github.com/cloudposse/terraform-aws-cloudwatch-logs/blob/main/variables.tf  module supports it. Then you could override principals in your code when instantiating the https://github.com/cloudposse/terraform-aws-api-gateway  module

Metadata

Metadata

Assignees

No one assigned

    Labels

    bug🐛 An issue with the system

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions