Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include protocol_version for the default target group #64

Merged
merged 6 commits into from
Aug 10, 2022
Merged

include protocol_version for the default target group #64

merged 6 commits into from
Aug 10, 2022

Conversation

azarudeena
Copy link
Contributor

what

  • ability to define the protocol version for the target groups.
  • made in this sync with the alb module

why

  • Need to have a case for GRPC service and health-checks were failing.

references

@azarudeena azarudeena requested review from a team as code owners August 10, 2022 11:06
nitrocode
nitrocode reviewed Aug 10, 2022
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
nitrocode
nitrocode reviewed Aug 10, 2022
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
@azarudeena azarudeena requested a review from nitrocode August 10, 2022 12:52
@nitrocode
Copy link
Member

/test all

@nitrocode nitrocode merged commit b8f198b into cloudposse:master Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

@joe-niland joe-niland Awaiting requested review from joe-niland joe-niland was automatically assigned from cloudposse/contributors

@RothAndrew RothAndrew Awaiting requested review from RothAndrew RothAndrew was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@azarudeena @nitrocode @cloudpossebot