Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional parameters for authenticated ingress rules #54

Merged
merged 4 commits into from
Jul 14, 2021
Merged

Add additional parameters for authenticated ingress rules #54

merged 4 commits into from
Jul 14, 2021

Conversation

sodre
Copy link
Contributor

@sodre sodre commented Jul 12, 2021 •
edited
Loading

what

  • Accept on_unauthenticated_request parameter
  • Accept authentication_request_extra_params

why

  • REST APIs usually work better with a "deny" rule instead of the default "authenticate" rule of on_unauthenticated_request.
  • REST APIs may require additional parameters to be passed in the URI.

@sodre sodre changed the title WIP: WIP: Add additional parameters for authenticated ingress rules Jul 12, 2021
@sodre sodre changed the title WIP: Add additional parameters for authenticated ingress rules Add additional parameters for authenticated ingress rules Jul 12, 2021
@sodre sodre marked this pull request as ready for review July 12, 2021 21:29
@sodre sodre requested review from a team as code owners July 12, 2021 21:29
@sodre sodre requested review from dotCipher and joe-niland July 12, 2021 21:29
@Gowiem
Copy link
Member

Gowiem commented Jul 14, 2021

/test all

@Gowiem Gowiem merged commit ab6033c into cloudposse:master Jul 14, 2021
@sodre sodre deleted the f/more-auth-options branch July 15, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gowiem Gowiem Gowiem approved these changes

@dotCipher dotCipher Awaiting requested review from dotCipher

@joe-niland joe-niland Awaiting requested review from joe-niland

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sodre @Gowiem @cloudpossebot