Skip to content

Conversation

@Nuru
Copy link
Contributor

@Nuru Nuru commented Feb 18, 2022

what

  • Update to go 1.17 and current dependencies

why

  • Security fixes

@Nuru Nuru requested review from aknysh and osterman February 18, 2022 04:52
github.com/google/go-github v17.0.0+incompatible
github.com/google/go-querystring v1.0.0 // indirect
golang.org/x/net v0.0.0-20200625001655-4c5254603344
github.com/google/go-querystring v1.1.0 // indirect
Copy link
Member

@aknysh aknysh Feb 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can use one require instead of two

also please update https://github.com/cloudposse/github-status-updater/blob/master/LICENSE#L189

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The format of go.mod changed as of go v1.17. See https://go.dev/ref/mod#graph-pruning

License updated.

Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments

@Nuru Nuru requested a review from aknysh February 18, 2022 05:19
@Nuru Nuru merged commit 0777ec9 into master Feb 18, 2022
@Nuru Nuru deleted the golang-version branch February 18, 2022 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants