Github enterprise and ssl insecure support #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e ssl connections
Contributor
Author
|
Hello =) any review ? |
osterman
approved these changes
Jun 30, 2020
Member
|
Sorry we missed this one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 3 new options in order to support Github Enterprise and insecure ssl connections
Options for Github Enterprise (works as a pair) :
-baseURL string
Base URL of github enterprise
-uploadURL string
Upload URL of github enterprise
This will trigger the creation of a github.NewEnterpriseClient instead of the usual github.NewClient
Option for insecure ssl connections:
-insecure
Ignore SSL certificate check
This change the RoundTrip to use an insecure transport