Skip to content

add -edit-comment-regex flag to edit existing comments#26

Merged
aknysh merged 1 commit intocloudposse:masterfrom
joemiller:edit-comment
Apr 10, 2021
Merged

add -edit-comment-regex flag to edit existing comments#26
aknysh merged 1 commit intocloudposse:masterfrom
joemiller:edit-comment

Conversation

@joemiller
Copy link
Contributor

@joemiller joemiller commented Apr 10, 2021

New flag -edit-comment-regex. Similar to -delete-comment-regex but edit existing comment(s) instead of deleting / recreating.

If there are no matching comments a new comment is created so that the call is idempotent. Users can run the same command in a CI pipeline to create or update comments.

I updated the readme.yaml but did not commit a regenerated README.md. There were too many differences (like missing badges) that I thought something might be wrong w/ my local setup.

I updated the google/go-github lib to the latest v34.0.0 to fix what I thought was a bug but turned out not to be. The code should work fine on v17.0.0 if that needs to be backed out.

closes #24

Similar to -delete-comment-regex but edit existing comment(s) instead of
deleting / recreating
@osterman osterman requested a review from aknysh April 10, 2021 00:33
@joemiller joemiller changed the title add -edit-comment-regex flag to edit in place comments add -edit-comment-regex flag to edit existing comments Apr 10, 2021
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @joemiller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

is it possible to support an edit mode instead of delete and replace?

2 participants