-
-
Notifications
You must be signed in to change notification settings - Fork 135
Improve Atmos help #959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Atmos help #959
Conversation
b1741d5 to
01bcd67
Compare
tests/snapshots/TestCLICommands_atmos_non-existent.stderr.golden
Outdated
Show resolved
Hide resolved
018793e to
b8a0fb9
Compare
b8a0fb9 to
bb9705b
Compare
tests/snapshots/TestCLICommands_atmos_atlantis_--help.stdout.golden
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
tests/test-cases/help-and-usage.yaml (2)
439-489: LGTM! New test cases enhance coverage.The new test cases for
atmos aboutandatmos versioncommands improve the test coverage for error handling and help output. The test in thefixtures/scenarios/subcommand-aliasdirectory is particularly valuable for verifying custom alias functionality.However, consider adding test cases for the following scenarios to make the test suite more comprehensive:
- Invalid alias configurations
- Multiple aliases for the same command
- Nested alias commands
371-378: Consider standardizing stdout/stderr expectations.While most test cases use the
difffield for output validation, this test case uses explicitstdoutandstderrfields. Consider standardizing the approach across all test cases.- stdout: - - "Flags:" - - "--affected-only" - - "--config-template" - stderr: - - "^$" + diff: + - "──────────────────────────────────────────────────────────────" + - "Update available!" + - "Atmos Releases:" + - "Install Atmos:" + - "Flags:" + - "--affected-only" + - "--config-template"
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
tests/test-cases/help-and-usage.yaml(15 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Build (windows-latest, windows)
- GitHub Check: website-deploy-preview
- GitHub Check: Summary
🔇 Additional comments (2)
tests/test-cases/help-and-usage.yaml (2)
4-4: LGTM! Consistent addition of snapshot testing.The addition of
snapshot: trueacross test cases is a solid improvement. This will help catch unintended changes in CLI output.Also applies to: 14-14, 24-24, 40-40, 56-56, 73-73, 90-90, 101-101, 113-113, 125-125, 135-135, 145-145, 161-161, 188-188, 199-199, 216-216, 233-233, 243-243, 259-259, 276-276, 287-287, 304-304, 321-321, 338-338, 356-356
32-37: Standardize help output expectations.The standardized diff expectations for help output will ensure consistent formatting and update notifications across all commands.
Also applies to: 48-53, 65-70, 82-87, 153-158, 169-174, 208-213, 225-230, 251-256, 267-272, 296-301, 313-318, 330-335, 348-353, 366-371, 403-408, 422-427
|
These changes were released in v1.162.0. |
what
We would be fixing the following UX issues with help in this pr:
atmos about non-existentshould show usage:Double dash in flags of

atmos terraform --helpand examples rendering using markdown if available.Fixed

atmos workflow --file example.yamlbug for markdown. Now it also exits with exit code 1.Updated Default error logger with markdown support.

Added custom alias help support so that alias in config should also be displayed in help.

Updated the workflow name invalid UI

Invalid custom command config now shows better help

Invalid flag usage added

why
references
Summary by CodeRabbit
Enhanced CLI Experience
atmos terraformnow specifies required subcommands and provides usage examples when invoked incorrectly.Updated Documentation
atmos validate editorconfig, enhancing user understanding of available flags and options.