Remove unwanted setHelpFunc

cmd/cmd_utils.go

@@ -481,11 +481,6 @@ func CheckForAtmosUpdateAndPrintMessage(atmosConfig schema.AtmosConfiguration) {
 	}
 }
 
-func customHelpMessageToUpgradeToAtmosLatestRelease(cmd *cobra.Command, args []string) {
-	originalHelpFunc(cmd, args)
-	CheckForAtmosUpdateAndPrintMessage(atmosConfig)
-}
-
 // Check Atmos is version command
 func isVersionCommand() bool {
 	return len(os.Args) > 1 && os.Args[1] == "version"

cmd/root.go

@@ -20,9 +20,6 @@ import (
 
 var atmosConfig schema.AtmosConfiguration
 
-// originalHelpFunc holds Cobra's original help function to avoid recursion.
-var originalHelpFunc func(*cobra.Command, []string)
-
 // RootCmd represents the base command when called without any subcommands
 var RootCmd = &cobra.Command{
 	Use:   "atmos",
@@ -96,14 +93,6 @@ func Execute() error {
 		}
 	}
 
-	// Save the original help function to prevent infinite recursion when overriding it.
-	// This allows us to call the original help functionality within our custom help function.
-	originalHelpFunc = RootCmd.HelpFunc()
-
-	// Override the help function with a custom one that adds an upgrade message after displaying help.
-	// This custom help function will call the original help function and then display the bordered message.
-	RootCmd.SetHelpFunc(customHelpMessageToUpgradeToAtmosLatestRelease)
-
 	// If CLI configuration was found, process its custom commands and command aliases
 	if initErr == nil {
 		err = processCustomCommands(atmosConfig, atmosConfig.Commands, RootCmd, true)

cmd/terraform.go

@@ -63,29 +63,31 @@ func terraformRun(cmd *cobra.Command, actualCmd *cobra.Command, args []string) e
 				return fmt.Errorf("unknown command %q for %q", args[0], cmd.CommandPath())
 			}
 		}
-		// Check for the latest Atmos release on GitHub and print update message
-		template := templates.GenerateFromBaseTemplate(actualCmd.Use, []templates.HelpTemplateSections{
-			templates.LongDescription,
-			templates.Usage,
-			templates.Aliases,
-			templates.Examples,
-			templates.AvailableCommands,
-			templates.Flags,
-			templates.GlobalFlags,
-			templates.NativeCommands,
-			templates.DoubleDashHelp,
-			templates.Footer,
-		})
+		// check if this is terraform --help command. TODO: check if this is the best way to do
+		if cmd == actualCmd {
+			template := templates.GenerateFromBaseTemplate(actualCmd.Use, []templates.HelpTemplateSections{
+				templates.LongDescription,
+				templates.Usage,
+				templates.Aliases,
+				templates.Examples,
+				templates.AvailableCommands,
+				templates.Flags,
+				templates.GlobalFlags,
+				templates.NativeCommands,
+				templates.DoubleDashHelp,
+				templates.Footer,
+			})
+			actualCmd.SetUsageTemplate(template)
+			cc.Init(&cc.Config{
+				RootCmd:  actualCmd,
+				Headings: cc.HiCyan + cc.Bold + cc.Underline,
+				Commands: cc.HiGreen + cc.Bold,
+				Example:  cc.Italic,
+				ExecName: cc.Bold,
+				Flags:    cc.Bold,
+			})
 
-		actualCmd.SetUsageTemplate(template)
-		cc.Init(&cc.Config{
-			RootCmd:  actualCmd,
-			Headings: cc.HiCyan + cc.Bold + cc.Underline,
-			Commands: cc.HiGreen + cc.Bold,
-			Example:  cc.Italic,
-			ExecName: cc.Bold,
-			Flags:    cc.Bold,
-		})
+		}
 
 		actualCmd.Help()
 		return nil

internal/tui/templates/base_template.go

@@ -73,6 +73,7 @@ Global Flags:
   {{.CommandPath}} [command]{{end}}`
 	case DoubleDashHelp:
 		return fmt.Sprintf(`
+
 The '--' (double-dash) can be used to signify the end of Atmos-specific options 
 and the beginning of additional native arguments and flags for the specific command being run.
 

internal/tui/templates/templater.go

@@ -122,6 +122,7 @@ func SetCustomUsageFunc(cmd *cobra.Command) error {
 			Flags,
 			GlobalFlags,
 			AdditionalHelpTopics,
+			DoubleDashHelp,
 			Footer,
 		}),
 	}