Repository navigation
feat(workflow): support tags and labels selectors - #2857
Erik Osterman (Cloud Posse) (osterman) merged 4 commits into
Conversation
|
Tip Atmos Pro
No affected stacks workflow was detected for this pull request. |
|
CodeRabbit (@coderabbitai) full review pls |
|
✅ Action performedFull review finished. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe workflow command accepts ChangesWorkflow selector forwarding
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant WorkflowCommand
participant ExecuteWorkflow
participant ControlCommandExecutor
participant AtmosStep
WorkflowCommand->>ExecuteWorkflow: Read --tags and --labels
ExecuteWorkflow->>ControlCommandExecutor: Pass workflow command filters
ControlCommandExecutor->>AtmosStep: Add stack, tags, and labels before --
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@internal/exec/workflow_utils.go`:
- Around line 825-829: Update the command-display construction near
AppendAtmosStepFlags so displayCmd includes the effective commandFilters.tags
and commandFilters.labels selectors, matching the forwarded args alongside
finalStack. Prefer deriving displayCmd from the final args to keep displayed and
executed commands consistent.
In `@pkg/workflow/control_executor_test.go`:
- Around line 321-330: Add independent table cases to TestAppendAtmosStepFlags
for Tags-only and Labels-only inputs, verifying each selector is forwarded
without Stack or the other selector; include at least one of these cases with
the existing "--" argument and preserve the expected ordering.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: ed1c4aba-88c5-444e-80db-ac6021e6275b
📒 Files selected for processing (12)
agent-skills/skills/atmos-workflows/references/workflow-syntax.mdcmd/workflow/workflow.gocmd/workflow/workflow_test.gointernal/exec/workflow.gointernal/exec/workflow_control_adapter.gointernal/exec/workflow_utils.gointernal/exec/workflow_utils_test.gopkg/workflow/control_executor.gopkg/workflow/control_executor_test.gowebsite/blog/2026-08-03-workflow-tags-and-labels.mdxwebsite/docs/cli/commands/workflow.mdxwebsite/src/data/roadmap.js
10a66ed
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2857 +/- ##
==========================================
+ Coverage 82.25% 82.27% +0.01%
==========================================
Files 1810 1810
Lines 175701 175728 +27
==========================================
+ Hits 144528 144572 +44
+ Misses 23455 23434 -21
- Partials 7718 7722 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
7c43da4
into
cloudposse:main
|
Tip Atmos Pro
No affected stacks workflow was detected for this pull request. |
|
These changes were released in v1.225.0-rc.7. |
what
--tagsand--labelsonatmos workflow, forwarding them to nestedtype: atmossteps alongside optional--stack.why
references
--labelsand--tagsto be passed into atmos workflows the same way--stacks can be #2852validation
go test ./internal/exec -run TestExecuteWorkflow_ForwardsCommandLineFilters -count=1go test ./pkg/workflow -run 'TestAppendAtmosStepFlags|TestControlCommandExecutorExecuteAtmos' -count=1go test ./cmd/workflow -run TestWorkflowSelectorFlags -count=1git diff --checkSummary by CodeRabbit
New Features
--tagsand--labelsselectors to workflow commands.--stackwhile preserving workflow ordering and execution behavior.Documentation