Repository navigation
feat: add ATMOS_CI_COMMENTS_ENABLED env var to override ci.comments.enabled - #2300
Conversation
…nabled Adds support for the ATMOS_CI_COMMENTS_ENABLED environment variable that enables or disables CI PR/MR comments, taking precedence over the YAML configuration when set. This allows selectively disabling comments in specific workflows without requiring a different YAML profile. - pkg/config/utils.go: handle ATMOS_CI_COMMENTS_ENABLED in processEnvVars - pkg/config/utils_test.go: add tests for the new env var - website/docs/cli/configuration/ci/comments.mdx: document the env var - website/docs/cli/configuration/ci/index.mdx: add env var to the table Agent-Logs-Url: https://github.com/cloudposse/atmos/sessions/37ea125b-02a8-40cc-ab9d-cb7e29ee8c54 Co-authored-by: osterman <52489+osterman@users.noreply.github.com>
- Replace os.Unsetenv with t.Setenv for proper test isolation - Add false→unchanged test case for invalid env var value Agent-Logs-Url: https://github.com/cloudposse/atmos/sessions/37ea125b-02a8-40cc-ab9d-cb7e29ee8c54 Co-authored-by: osterman <52489+osterman@users.noreply.github.com>
Dependency Review✅ No vulnerabilities or license issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2300 +/- ##
==========================================
+ Coverage 77.18% 77.21% +0.02%
==========================================
Files 1070 1070
Lines 101503 101511 +8
==========================================
+ Hits 78347 78381 +34
+ Misses 18837 18811 -26
Partials 4319 4319
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Warning Release Documentation RequiredThis PR is labeled
|
|
Tip Atmos Pro
No affected stacks workflow was detected for this pull request. |
|
Warning Release Documentation RequiredThis PR is labeled
|
|
Warning Release Documentation RequiredThis PR is labeled
|
|
Warning Release Documentation RequiredThis PR is labeled
|
Add shipped milestone to the ci-cd initiative in the roadmap for PR #2300: ATMOS_CI_COMMENTS_ENABLED environment variable that overrides ci.comments.enabled in atmos.yaml, allowing CI pipelines to toggle PR comments per-pipeline without modifying config files. Update ci-cd initiative progress from 88% to 89%. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Warning Release Documentation RequiredThis PR is labeled
|
Add changelog blog post for PR #2300 (minor label, CI enforced). Link the roadmap milestone to the blog slug via changelog field. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
These changes were released in v1.215.0-rc.6. |
These nine carried `authors: [atmos]`, the generic team byline the changelog skill says to avoid. Attribution follows the pull request that implemented the feature, not the commit that added or later renamed the post file. That distinction mattered. Five of the nine appear in `git log --diff-filter=A` as added by #2753, a chronology-correction pass that renamed post files to match their publication dates. Following renames instead points at the real work: list-components-fix #1949 osterman chdir-config-isolation #1941 osterman introducing-atmos-lsp #2030 aknysh introducing-atmos-ai #2030 aknysh ci-comments-env-var #2300 osterman list-instances-matrix #2322 johncblandii terraform-all-dependency-order-wired-up #2486 thejrose1984 dotenv-include-support #1930 osterman toolchain-proxies #1687 osterman Each byline is the GitHub pull request author rather than the git commit author, because squash merges attribute the commit to whoever merged it. #2300 needed a judgment call. It was authored by `app/copilot-swe-agent`, a bot. The byline goes to osterman, who is the assignee and the human who drove the change. A bot is not a contributor byline, and the person who merged it (aknysh) did not do the work either. johncblandii and thejrose1984 were missing from `authors.yml` and are added here, which the changelog skill requires in the same change that references them. thejrose1984 publishes no display name on GitHub, so the login stands in rather than inventing one. Verified: all 263 posts now resolve to a real `authors.yml` entry, no post carries the generic byline, and the site builds with no author warnings. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
ci.comments.enabledcould only be controlled viaatmos.yaml, making it impossible to disable PR/MR comments in specific workflows without maintaining separate config profiles.Changes
pkg/config/utils.go: ParseATMOS_CI_COMMENTS_ENABLEDinprocessEnvVars(), overridingatmosConfig.CI.Comments.Enabledwhen set. Follows the same pattern asATMOS_VERSION_CHECK_ENABLED. Invalid values emit a warning and leave the config unchanged.pkg/config/utils_test.go: Tests coveringtrue/false/1/0values, unset behavior (YAML value preserved), and invalid input (config unchanged in both directions).website/docs/cli/configuration/ci/comments.mdx: Document the new env var in the config reference and a dedicated Environment Variables section.website/docs/cli/configuration/ci/index.mdx: AddATMOS_CI_COMMENTS_ENABLEDto the CI environment variables table.Usage
The env var takes precedence over the YAML value when set; when unset, the YAML value is used unchanged.