Skip to content

feat: add ATMOS_CI_COMMENTS_ENABLED env var to override ci.comments.enabled - #2300

Merged
Andriy Knysh (aknysh) merged 7 commits into
mainfrom
copilot/add-env-to-toggle-ci-comments
Apr 10, 2026
Merged

Andriy Knysh (aknysh) merged 7 commits into
mainfrom
copilot/add-env-to-toggle-ci-comments

Conversation

Copilot AI commented Apr 7, 2026 •

Copy link
Copy Markdown
Contributor

ci.comments.enabled could only be controlled via atmos.yaml, making it impossible to disable PR/MR comments in specific workflows without maintaining separate config profiles.

Changes

  • pkg/config/utils.go: Parse ATMOS_CI_COMMENTS_ENABLED in processEnvVars(), overriding atmosConfig.CI.Comments.Enabled when set. Follows the same pattern as ATMOS_VERSION_CHECK_ENABLED. Invalid values emit a warning and leave the config unchanged.
  • pkg/config/utils_test.go: Tests covering true/false/1/0 values, unset behavior (YAML value preserved), and invalid input (config unchanged in both directions).
  • website/docs/cli/configuration/ci/comments.mdx: Document the new env var in the config reference and a dedicated Environment Variables section.
  • website/docs/cli/configuration/ci/index.mdx: Add ATMOS_CI_COMMENTS_ENABLED to the CI environment variables table.

Usage

# atmos.yaml — default enabled for most workflows
ci:
  comments:
    enabled: true
# GitHub Actions — disable comments in a specific workflow
- name: Plan (no comments)
  env:
    ATMOS_CI_COMMENTS_ENABLED: "false"
  run: atmos terraform plan ...

The env var takes precedence over the YAML value when set; when unset, the YAML value is used unchanged.

Copilot AI linked an issue Apr 7, 2026 that may be closed by this pull request
@mergify mergify Bot added triage Needs triage wip Work in Progress: Not ready for final review or merge labels Apr 7, 2026
Copilot AI and others added 2 commits April 7, 2026 23:39
…nabled

Adds support for the ATMOS_CI_COMMENTS_ENABLED environment variable that
enables or disables CI PR/MR comments, taking precedence over the YAML
configuration when set. This allows selectively disabling comments in
specific workflows without requiring a different YAML profile.

- pkg/config/utils.go: handle ATMOS_CI_COMMENTS_ENABLED in processEnvVars
- pkg/config/utils_test.go: add tests for the new env var
- website/docs/cli/configuration/ci/comments.mdx: document the env var
- website/docs/cli/configuration/ci/index.mdx: add env var to the table

Agent-Logs-Url: https://github.com/cloudposse/atmos/sessions/37ea125b-02a8-40cc-ab9d-cb7e29ee8c54

Co-authored-by: osterman <52489+osterman@users.noreply.github.com>
- Replace os.Unsetenv with t.Setenv for proper test isolation
- Add false→unchanged test case for invalid env var value

Agent-Logs-Url: https://github.com/cloudposse/atmos/sessions/37ea125b-02a8-40cc-ab9d-cb7e29ee8c54

Co-authored-by: osterman <52489+osterman@users.noreply.github.com>
Copilot AI changed the title [WIP] Add environment variable to enable/disable CI comments feat: add ATMOS_CI_COMMENTS_ENABLED env var to override ci.comments.enabled Apr 7, 2026
@mergify mergify Bot removed the wip Work in Progress: Not ready for final review or merge label Apr 7, 2026
@osterman Erik Osterman (Cloud Posse) (osterman) added the minor New features that do not break anything label Apr 8, 2026
@github-actions github-actions Bot added the size/m Medium size PR label Apr 8, 2026
@github-actions

github-actions Bot commented Apr 8, 2026 •

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA c7ffb67.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@codecov

codecov Bot commented Apr 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.21%. Comparing base (26eb490) to head (c7ffb67).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2300      +/-   ##
==========================================
+ Coverage   77.18%   77.21%   +0.02%     
==========================================
  Files        1070     1070              
  Lines      101503   101511       +8     
==========================================
+ Hits        78347    78381      +34     
+ Misses      18837    18811      -26     
  Partials     4319     4319              
Flag Coverage Δ
unittests 77.21% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/config/utils.go 88.20% <100.00%> (+0.15%) ⬆️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@osterman
Erik Osterman (Cloud Posse) (osterman) marked this pull request as ready for review April 9, 2026 22:06
@github-actions

github-actions Bot commented Apr 9, 2026

Copy link
Copy Markdown

Warning

Release Documentation Required

This PR is labeled minor or major and requires documentation updates:

  • Changelog entry - Add a blog post in website/blog/YYYY-MM-DD-feature-name.mdx
  • Roadmap update - Update website/src/data/roadmap.js with the new milestone

Alternatively: If this change doesn't require release documentation, remove the minor or major label.

@atmos-pro

atmos-pro Bot commented Apr 10, 2026 •

Copy link
Copy Markdown
Contributor

Tip

Atmos Pro  

No affected stacks workflow was detected for this pull request.
If this is expected, no action is needed.
Learn More.

@github-actions

Copy link
Copy Markdown

Warning

Release Documentation Required

This PR is labeled minor or major and requires documentation updates:

  • Changelog entry - Add a blog post in website/blog/YYYY-MM-DD-feature-name.mdx
  • Roadmap update - Update website/src/data/roadmap.js with the new milestone

Alternatively: If this change doesn't require release documentation, remove the minor or major label.

@github-actions

Copy link
Copy Markdown

Warning

Release Documentation Required

This PR is labeled minor or major and requires documentation updates:

  • Changelog entry - Add a blog post in website/blog/YYYY-MM-DD-feature-name.mdx
  • Roadmap update - Update website/src/data/roadmap.js with the new milestone

Alternatively: If this change doesn't require release documentation, remove the minor or major label.

@github-actions

Copy link
Copy Markdown

Warning

Release Documentation Required

This PR is labeled minor or major and requires documentation updates:

  • Changelog entry - Add a blog post in website/blog/YYYY-MM-DD-feature-name.mdx
  • Roadmap update - Update website/src/data/roadmap.js with the new milestone

Alternatively: If this change doesn't require release documentation, remove the minor or major label.

Add shipped milestone to the ci-cd initiative in the roadmap for PR
#2300: ATMOS_CI_COMMENTS_ENABLED environment variable that overrides
ci.comments.enabled in atmos.yaml, allowing CI pipelines to toggle PR
comments per-pipeline without modifying config files.

Update ci-cd initiative progress from 88% to 89%.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions

github-actions Bot commented Apr 10, 2026 •

Copy link
Copy Markdown

Warning

Release Documentation Required

This PR is labeled minor or major and requires documentation updates:

  • Changelog entry - Add a blog post in website/blog/YYYY-MM-DD-feature-name.mdx
  • Roadmap update ✅

Alternatively: If this change doesn't require release documentation, remove the minor or major label.

Add changelog blog post for PR #2300 (minor label, CI enforced).
Link the roadmap milestone to the blog slug via changelog field.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@aknysh
Andriy Knysh (aknysh) merged commit 5ee9d81 into main Apr 10, 2026
58 checks passed
@aknysh
Andriy Knysh (aknysh) deleted the copilot/add-env-to-toggle-ci-comments branch April 10, 2026 22:18
@atmos-pro

atmos-pro Bot commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

Note

Atmos Pro  

Waiting for your GitHub Actions workflow to upload affected stacks.
Learn More.

@github-actions

Copy link
Copy Markdown

These changes were released in v1.215.0-rc.6.

Erik Osterman (Cloud Posse) (osterman) added a commit that referenced this pull request Aug 3, 2026
These nine carried `authors: [atmos]`, the generic team byline the changelog
skill says to avoid. Attribution follows the pull request that implemented the
feature, not the commit that added or later renamed the post file.

That distinction mattered. Five of the nine appear in `git log --diff-filter=A`
as added by #2753, a chronology-correction pass that renamed post files to match
their publication dates. Following renames instead points at the real work:

  list-components-fix                    #1949  osterman
  chdir-config-isolation                 #1941  osterman
  introducing-atmos-lsp                  #2030  aknysh
  introducing-atmos-ai                   #2030  aknysh
  ci-comments-env-var                    #2300  osterman
  list-instances-matrix                  #2322  johncblandii
  terraform-all-dependency-order-wired-up #2486  thejrose1984
  dotenv-include-support                 #1930  osterman
  toolchain-proxies                      #1687  osterman

Each byline is the GitHub pull request author rather than the git commit author,
because squash merges attribute the commit to whoever merged it.

#2300 needed a judgment call. It was authored by `app/copilot-swe-agent`, a bot.
The byline goes to osterman, who is the assignee and the human who drove the
change. A bot is not a contributor byline, and the person who merged it (aknysh)
did not do the work either.

johncblandii and thejrose1984 were missing from `authors.yml` and are added here,
which the changelog skill requires in the same change that references them.
thejrose1984 publishes no display name on GitHub, so the login stands in rather
than inventing one.

Verified: all 263 posts now resolve to a real `authors.yml` entry, no post
carries the generic byline, and the site builds with no author warnings.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

This branch was successfully deployed

1 active deployment
preview — c7ffb678 Deployed Apr 10, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor New features that do not break anything size/m Medium size PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ADD missing ENV to disable/enable CI comments

3 participants