Skip to content

feat(vendor): warn when vendoring from an archived GitHub repository - #2175

Open
RB (nitrocode) with Copilot wants to merge 24 commits into
mainfrom
copilot/warn-when-vendor-archived-repo
Open

RB (nitrocode) with Copilot wants to merge 24 commits into
mainfrom
copilot/warn-when-vendor-archived-repo

Conversation

Copilot AI commented Mar 12, 2026 •

Copy link
Copy Markdown
Contributor
  • Add logger concurrency guard test (Warn + concurrent SetOutput) in pkg/logger/atmos_logger_test.go
  • Fix env-var docs phrasing in website/docs/cli/environment-variables.mdx (remove os.Setenv note)
  • Add ATMOS_GITHUB_ARCHIVED_CHECK_TIMEOUT env-var section to website/docs/cli/configuration/vendor.mdx
  • Add TODO comments above warnIfArchivedGitHubRepo calls in internal/exec/vendor_utils.go and internal/exec/vendor_component_utils.go
  • Replace fmt.Sprintf("%s/%s", owner, repo) with owner + "/" + repo in vendor_github_archive.go (removed fmt import)
  • Rename github import alias to ghclient in pkg/github/repo_test.go
  • Update CHANGELOG.md with blog/docs links under Breaking Changes
  • go test -race ./pkg/logger/... ./pkg/github/... — all pass, no data races
Original prompt

This section details on the original issue you should resolve

<issue_title>Warn when vendoring from an archived repo</issue_title>
<issue_description>### Describe the Feature

Warn when vendoring from an archived repo

Expected Behavior

warning shown

Use Case

When vendoring

Describe Ideal Solution

See above

Alternatives Considered

No response

Additional Context

No response</issue_description>

<agent_instructions>Use the PR template. Use semantic commits. Think deeply. Use a semantic PR title.</agent_instructions>

Comments on the Issue (you are Copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@mergify mergify Bot added triage Needs triage wip Work in Progress: Not ready for final review or merge labels Mar 12, 2026
Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
Copilot AI changed the title [WIP] Add warning when vendoring from an archived repo feat(vendor): warn when vendoring from an archived GitHub repository Mar 12, 2026
@mergify mergify Bot removed the wip Work in Progress: Not ready for final review or merge label Mar 12, 2026
@nitrocode RB (nitrocode) added the minor New features that do not break anything label Mar 12, 2026
@github-actions github-actions Bot added the size/m Medium size PR label Mar 12, 2026
@github-actions

Copy link
Copy Markdown

Warning

Release Documentation Required

This PR is labeled minor or major and requires documentation updates:

  • Changelog entry - Add a blog post in website/blog/YYYY-MM-DD-feature-name.mdx
  • Roadmap update - Update website/src/data/roadmap.js with the new milestone

Alternatively: If this change doesn't require release documentation, remove the minor or major label.

1 similar comment
@github-actions

Copy link
Copy Markdown

Warning

Release Documentation Required

This PR is labeled minor or major and requires documentation updates:

  • Changelog entry - Add a blog post in website/blog/YYYY-MM-DD-feature-name.mdx
  • Roadmap update - Update website/src/data/roadmap.js with the new milestone

Alternatively: If this change doesn't require release documentation, remove the minor or major label.

@github-actions

github-actions Bot commented Mar 12, 2026 •

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 46ece28.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

…ning

Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
@osterman

This comment was marked as outdated.

… URLs; add tests

Co-authored-by: osterman <52489+osterman@users.noreply.github.com>

This comment was marked as outdated.

@codecov

codecov Bot commented Mar 13, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.30818% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.22%. Comparing base (01541b6) to head (46ece28).
⚠️ Report is 386 commits behind head on main.

Files with missing lines Patch % Lines
pkg/github/repo.go 83.16% 13 Missing and 4 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2175      +/-   ##
==========================================
+ Coverage   77.18%   77.22%   +0.03%     
==========================================
  Files        1014     1016       +2     
  Lines       95883    96036     +153     
==========================================
+ Hits        74010    74166     +156     
+ Misses      17688    17686       -2     
+ Partials     4185     4184       -1     
Flag Coverage Δ
unittests 77.22% <89.30%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/exec/vendor_component_utils.go 32.30% <100.00%> (+0.52%) ⬆️
internal/exec/vendor_github_archive.go 100.00% <100.00%> (ø)
internal/exec/vendor_utils.go 70.39% <100.00%> (+0.19%) ⬆️
pkg/logger/atmos_logger.go 95.65% <100.00%> (+1.28%) ⬆️
pkg/logger/global.go 83.33% <100.00%> (ø)
pkg/logger/log.go 92.50% <100.00%> (+0.19%) ⬆️
pkg/github/repo.go 83.16% <83.16%> (ø)

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nitrocode
RB (nitrocode) marked this pull request as ready for review March 13, 2026 16:48
@nitrocode
RB (nitrocode) requested a review from a team as a code owner March 13, 2026 16:48
@coderabbitai

This comment was marked as outdated.

@coderabbitai

This comment was marked as outdated.

…riter; add test

Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
Agent-Logs-Url: https://github.com/cloudposse/atmos/sessions/56d5843f-6254-40d0-b211-9119b009d576
@nitrocode

This comment was marked as outdated.

@coderabbitai

This comment was marked as outdated.

@mergify

mergify Bot commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

💥 This pull request now has conflicts. Could you fix it @Copilot? 🙏

@mergify mergify Bot added the conflict This PR has conflicts label Mar 24, 2026
…, doc wording fix

Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
Agent-Logs-Url: https://github.com/cloudposse/atmos/sessions/43fc1142-68ca-45ba-b956-df8d7315c945
@nitrocode

This comment was marked as outdated.

1 similar comment
@nitrocode

This comment was marked as outdated.

@coderabbitai

This comment was marked as outdated.

@coderabbitai

This comment was marked as outdated.

@coderabbitai

This comment was marked as outdated.

@coderabbitai

This comment was marked as outdated.

@coderabbitai

This comment was marked as outdated.

@nitrocode

This comment was marked as outdated.

@coderabbitai

This comment was marked as outdated.

@coderabbitai

This comment was marked as outdated.

@mergify

mergify Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

💥 This pull request now has conflicts. Could you fix it @Copilot? 🙏

@mergify mergify Bot added the conflict This PR has conflicts label Jun 10, 2026

This branch was successfully deployed

1 active (outdated) deployment
preview — d297fa03 Deployed Mar 24, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conflict This PR has conflicts minor New features that do not break anything size/l Large size PR triage Needs triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warn when vendoring from an archived repo

3 participants