Repository navigation
Fix identity prompts to respect --interactive flag - #2130
Merged
Merged
Conversation
Copilot started work on behalf of
Erik Osterman (Cloud Posse) (osterman)
March 3, 2026 15:38
View session
- Updated isInteractive() in pkg/auth/manager.go to check viper for --interactive flag - Added viper import to support flag checking - Added comprehensive tests for --interactive flag behavior - Updated existing tests to preserve viper state Co-authored-by: osterman <52489+osterman@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix identity prompts to follow interactive settings
Fix identity prompts to respect --interactive flag
Mar 3, 2026
Erik Osterman (Cloud Posse) (osterman)
marked this pull request as ready for review
March 3, 2026 15:58
Erik Osterman (Cloud Posse) (osterman)
requested a review
from a team
as a code owner
March 3, 2026 15:58
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2130 +/- ##
=======================================
Coverage 76.57% 76.58%
=======================================
Files 832 832
Lines 79500 79502 +2
=======================================
+ Hits 60879 60884 +5
+ Misses 14822 14820 -2
+ Partials 3799 3798 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Andriy Knysh (aknysh)
approved these changes
Mar 4, 2026
|
These changes were released in v1.208.1-test.0. |
Igor Rodionov (goruha)
added a commit
that referenced
this pull request
Mar 9, 2026
…raform-plan * osterman/native-ci-terraform: (28 commits) feat: Add source cache TTL for JIT-vendored components (#2138) feat: Per-target version overrides in vendor manifests (#2141) docs: Add PRD for browser-based auth in aws/user identity (#1887) docs: Add EKS kubeconfig authentication integration PRD (#1884) fix: correct marketplace.json schema and update docs with install/uninstall commands (#2142) fix: propagate auth to all YAML functions in multi-component execution (#2140) fix: Use atmos_component for source provisioner workdir paths (#2137) Fix identity prompts to respect --interactive flag (#2130) Increase PR size thresholds to accommodate AI-assisted development (#2136) docs: Add Azure authentication provider documentation (#2132) fix: propagate component-type level dependencies through stack processor (#2127) fix: Add retry and missing workflow step properties to all schema copies (#2113) Exclude unsupported windows/arm from goreleaser build matrix (#2133) Add AI Agent Skills for LLM-Powered Infrastructure Development (#2121) Fix: Convert toolchain paths to absolute in PATH to resolve exec.LookPath failures (#2095) Fix workdir collision for component instances sharing base component (#2093) fix(auth): propagate TTY state to subprocesses for SSO device flow in workflows (#2126) fix(security): prevent SSRF in GitHub OIDC token URL handling (CWE-918) (#2106) Fix #2112: add workflow_retry definition and retry property to workflow step schema (#2114) fix(auth): auto-detect GitHub Actions WIF with proper audience, host validation, and lazy GSM init (#2109) ...
|
These changes were released in v1.208.1-test.9. |
|
These changes were released in v1.208.1-test.10. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identity selection prompts appeared even when
--interactive=falsewas specified. TheisInteractive()function inpkg/auth/manager.gochecked TTY and CI status but not the flag itself.Changes
isInteractive()to checkviper.GetBool("interactive")before TTY/CI checksImplementation
Now aligns with the existing pattern in
pkg/flags/interactive.go.Behavior
atmos list stacks --interactive=falseatmos list stacks(default)ATMOS_INTERACTIVE=false atmos list stacksOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.