Remove custom column docs #1262
Conversation
|
Warning This PR is blocked from merging because a required semver label is missing. You'll need to add one before this PR can be merged. |
|
Important Cloud Posse Engineering Team Review RequiredThis pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes. To expedite this process, reach out to us on Slack in the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1262 +/- ##
==========================================
+ Coverage 48.06% 48.15% +0.09%
==========================================
Files 233 233
Lines 25441 25441
==========================================
+ Hits 12228 12251 +23
+ Misses 11624 11597 -27
- Partials 1589 1593 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
📝 WalkthroughWalkthroughThe changes remove all documentation related to customizing output columns for Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
tests/fixtures/scenarios/vendor/atmos.yaml (3)
32-35: Clean up commented-out examples
The disabledDescriptionandFolderentries are vestigial and only add noise. Unless they serve a clear purpose for future tests, consider removing them.
36-36: Refine explanatory comment
Switch to a single#and tighten the phrasing for clarity. For example:# Custom columns are currently unsupported; output always shows the default folder name.
37-37: Remove trailing whitespace
There’s a blank line containing stray spaces—trimming it will clean up the fixture.🧰 Tools
🪛 YAMLlint (1.37.1)
[error] 37-37: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (9)
tests/fixtures/scenarios/vendor/atmos.yaml(1 hunks)website/docs/cli/commands/list/list-components.mdx(0 hunks)website/docs/cli/commands/list/list-metadata.mdx(0 hunks)website/docs/cli/commands/list/list-settings.mdx(0 hunks)website/docs/cli/commands/list/list-stacks.mdx(0 hunks)website/docs/cli/commands/list/list-values.mdx(0 hunks)website/docs/cli/commands/list/list-vars.mdx(0 hunks)website/docs/cli/commands/list/list-workflows.mdx(0 hunks)website/docs/cli/commands/list/usage.mdx(0 hunks)
💤 Files with no reviewable changes (8)
- website/docs/cli/commands/list/list-vars.mdx
- website/docs/cli/commands/list/list-values.mdx
- website/docs/cli/commands/list/list-components.mdx
- website/docs/cli/commands/list/list-metadata.mdx
- website/docs/cli/commands/list/list-settings.mdx
- website/docs/cli/commands/list/list-stacks.mdx
- website/docs/cli/commands/list/usage.mdx
- website/docs/cli/commands/list/list-workflows.mdx
🧰 Additional context used
🪛 YAMLlint (1.37.1)
tests/fixtures/scenarios/vendor/atmos.yaml
[error] 37-37: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Acceptance Tests (macos-latest, macos)
- GitHub Check: Acceptance Tests (windows-latest, windows)
- GitHub Check: Acceptance Tests (ubuntu-latest, linux)
- GitHub Check: Summary
🔇 Additional comments (1)
tests/fixtures/scenarios/vendor/atmos.yaml (1)
22-31: Validatelist.columnsconfiguration
The newlist.columnsblock is well-formed, but since custom columns aren’t supported yet (per PR #1262 objectives), confirm that this fixture’s scenario test expects the default behavior (ignoring these entries).
|
Ugh, really? We didn't land support for custom columns? Could have sworn we had this. |
|
We're going to look into why this isn't working |
what
atmos list vendorhas code to support custom columns but upon further testing does not utilize thevalueand only prints based on if the column name is one of the predefined.atmos listcommands do not currently support custom columns.why
references
Summary by CodeRabbit
atmos listcommands.