Skip to content

fix functions with empty cells #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 2, 2017
Merged

fix functions with empty cells #91

merged 2 commits into from
Jun 2, 2017

Conversation

llllllllll
Copy link
Contributor

addresses #73

@codecov-io
Copy link

codecov-io commented May 31, 2017 •
edited
Loading

Codecov Report

Merging #91 into master will increase coverage by 0.74%.
The diff coverage is 82.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage   79.88%   80.62%   +0.74%     
==========================================
  Files           2        2              
  Lines         522      542      +20     
  Branches      109      111       +2     
==========================================
+ Hits          417      437      +20     
  Misses         75       75              
  Partials       30       30
Impacted Files Coverage Δ
cloudpickle/cloudpickle.py 80.51% <82.35%> (+0.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb211a9...d14b24a. Read the comment docs.

pitrou
pitrou reviewed May 31, 2017
View reviewed changes
cloudpickle/cloudpickle.py Outdated
return _empty_cell_value


@object.__new__
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be less cryptic? :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have wrapped this in a named function with a docstring.

Idk if this is better.

pitrou
pitrou reviewed Jun 2, 2017
View reviewed changes
cloudpickle/cloudpickle.py
return _empty_cell_value


def instance(cls):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha :-)

Copy link
Member

@rgbkrk rgbkrk Jun 2, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this just go back to @object.__new__? 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's ok to me :-)

@pitrou pitrou merged commit c89dc9d into cloudpipe:master Jun 2, 2017
@pitrou pitrou mentioned this pull request Jun 2, 2017
Closed
@llllllllll llllllllll deleted the empty-cell branch June 2, 2017 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgbkrk rgbkrk rgbkrk left review comments

@pitrou pitrou pitrou left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@llllllllll @codecov-io @rgbkrk @pitrou