Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cluster) configurable max token validity (#518) #634

Merged
merged 20 commits into from
Oct 29, 2024
Merged

feat(cluster) configurable max token validity (#518) #634

merged 20 commits into from
Oct 29, 2024

Conversation

gciezkowski-acc
Copy link
Contributor

@gciezkowski-acc gciezkowski-acc commented Oct 10, 2024 •
edited
Loading

Description

I added the configurable parameter max token validity to the cluster specification, ensuring it does not negatively impact existing clusters.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Remove if not applicable

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@gciezkowski-acc gciezkowski-acc self-assigned this Oct 10, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation feature core-apis labels Oct 10, 2024
@gciezkowski-acc gciezkowski-acc force-pushed the feat/518_configurable_max_token_validity branch 10 times, most recently from 9ed7021 to 3ebd585 Compare October 16, 2024 12:51
@gciezkowski-acc gciezkowski-acc force-pushed the feat/518_configurable_max_token_validity branch 2 times, most recently from d6e2dc4 to f4b0b36 Compare October 16, 2024 14:00
@gciezkowski-acc gciezkowski-acc marked this pull request as ready for review October 16, 2024 14:14
@gciezkowski-acc gciezkowski-acc requested review from a team as code owners October 16, 2024 14:14
IvoGoman
IvoGoman reviewed Oct 18, 2024
View reviewed changes
pkg/admission/cluster_webhook.go Outdated Show resolved Hide resolved
pkg/apis/greenhouse/v1alpha1/cluster_types.go Outdated Show resolved Hide resolved
@gciezkowski-acc gciezkowski-acc force-pushed the feat/518_configurable_max_token_validity branch from 202a624 to 026e021 Compare October 21, 2024 09:50
kengou
kengou requested changes Oct 21, 2024
View reviewed changes
pkg/admission/cluster_webhook.go Outdated Show resolved Hide resolved
@gciezkowski-acc gciezkowski-acc force-pushed the feat/518_configurable_max_token_validity branch 2 times, most recently from 9440db8 to c742bea Compare October 22, 2024 11:58
@gciezkowski-acc gciezkowski-acc force-pushed the feat/518_configurable_max_token_validity branch 2 times, most recently from 4c1fdee to 1abe7ca Compare October 24, 2024 08:22
@gciezkowski-acc gciezkowski-acc force-pushed the feat/518_configurable_max_token_validity branch from bfb1d5b to 67c2565 Compare October 28, 2024 09:32
gciezkowski-acc and others added 19 commits October 28, 2024 16:02
@gciezkowski-acc
feat(cluster) configurable max token validity (#518)
4bf825f
@gciezkowski-acc
feat(cluster) Unit tests for MaxTokenVelidity (#518)
641fab7
@gciezkowski-acc
feat(cluster) Make deal with refresh token (#518)
fe6b895
@gciezkowski-acc
feat(cluster) Unit tests and avoid impact to existing clusters (#518)
f3109b1
@gciezkowski-acc
feat(cluster) Rebase side effecte (#518)
45c7030
@gciezkowski-acc
feat(cluster) Add missing things to the chart
c527021
@gciezkowski-acc
feat(cluster) Fix errors in tests (#518)
2e9bb2c
@gciezkowski-acc
feat(cluster) Add maxTokenValidity to documentation
c81d9b4
@gciezkowski-acc
Automatic generation of CRD API Docs
0a693e4
@gciezkowski-acc
Automatic application of license header
32456b6
@gciezkowski-acc
feat(cluster) KubeConfig struct (#518)
14c2044
@gciezkowski-acc
Automatic application of license header
3db0e0c
@gciezkowski-acc
Automatic generation of CRD API Docs
8a48382
@gciezkowski-acc
Automatic generation of CRD API Docs
3703629
@gciezkowski-acc
Revert "feat(clusters) Nodes created in namespace (#518)"
a3a92fb 
This reverts commit 585f2dc.
@gciezkowski-acc
feat(clusters) Minimum value of TokenValidity (#518)
2f009ea
@gciezkowski-acc
Automatic generation of CRD API Docs
ca302d7
@gciezkowski-acc
feat(clusters) RenewRemoteClusterBearerTokenAfter to current value in…
19bba4f 
… reconciler
@gciezkowski-acc
feat(clusters) Move validation to kubebuilder (#518)
aad9425
@gciezkowski-acc gciezkowski-acc force-pushed the feat/518_configurable_max_token_validity branch from da30350 to aad9425 Compare October 28, 2024 15:04
@gciezkowski-acc gciezkowski-acc merged commit 90cf2d1 into main Oct 29, 2024
@gciezkowski-acc gciezkowski-acc deleted the feat/518_configurable_max_token_validity branch October 29, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvoGoman IvoGoman IvoGoman approved these changes

@kengou kengou kengou approved these changes

@abhijith-darshan abhijith-darshan Awaiting requested review from abhijith-darshan

Assignees

@gciezkowski-acc gciezkowski-acc

Labels
core-apis documentation Improvements or additions to documentation feature helm-charts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] - Configurable maxTokenValidity for Cluster
4 participants
@gciezkowski-acc @kengou @IvoGoman @abhijith-darshan