Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(teammembership): trigger on scim config change #597

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

Zaggy21
Copy link
Contributor

@Zaggy21 Zaggy21 commented Sep 19, 2024

Description

TeamMembershipUpdater controller now watches for changes in Organization CR and triggers reconciliation for all Teams in Organization. This way a change in SCIM config in Organization will reach respective Teams.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Added a test for TeamMembershipUpdater to check if all Teams in Organization are reconciled after SCIM config change.

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Zaggy21 Zaggy21 requested a review from a team as a code owner September 19, 2024 07:55
@Zaggy21 Zaggy21 linked an issue Sep 19, 2024 that may be closed by this pull request
@Zaggy21 Zaggy21 merged commit 985d5b6 into main Sep 23, 2024
8 checks passed
@Zaggy21 Zaggy21 deleted the fix/teammembershipupdater-trigger-on-scimconfig-change branch September 23, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - TeamMembershipUpdater does not run Organization CR changes
2 participants