Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: helm controller recreate CRDs #577

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Conversation

Zaggy21
Copy link
Contributor

@Zaggy21 Zaggy21 commented Sep 17, 2024

Description

This PR adds a difference check for CRDs in helm release in HelmController and re-creates CRDs on upgrade if any were deleted from the remote cluster.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

I've added tests for CRD re-creation in pkg/helm/helm_test.go and in pkg/controllersplugin/remote_cluster_test.go.

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Zaggy21 Zaggy21 requested a review from a team as a code owner September 17, 2024 13:30
@Zaggy21 Zaggy21 linked an issue Sep 17, 2024 that may be closed by this pull request
3 tasks
@Zaggy21 Zaggy21 merged commit 25719d8 into main Sep 23, 2024
8 checks passed
@Zaggy21 Zaggy21 deleted the feat/helm-controller-recreate-crds branch September 23, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] - Helm Controller recreate CRDs
2 participants