Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build) multiarch images #566

Merged
merged 8 commits into from
Sep 16, 2024
Merged

fix(build) multiarch images #566

merged 8 commits into from
Sep 16, 2024

Conversation

kengou
Copy link
Contributor

@kengou kengou commented Sep 12, 2024

Description

fix multi arch image build
replace GOBIN with GOPATH
Install will install to GOPATH/bin anyway

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

replace GOBIN with GOPATH
Install will install to GOPATH/bin anyway
@kengou kengou requested review from a team as code owners September 12, 2024 20:54
@kengou kengou linked an issue Sep 12, 2024 that may be closed by this pull request
@kengou kengou merged commit 291d4d1 into main Sep 16, 2024
8 checks passed
@kengou kengou deleted the fix/189/build-multiarch branch September 16, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - Fix docker buildx for multiarch for docker images
2 participants