Skip to content

Commit

Permalink
Revert "fix(service-proxy): only enqueue if watched resource changed (#…
Browse files Browse the repository at this point in the history
…557)" (#704)

This reverts commit f4c2396.
  • Loading branch information
IvoGoman authored Nov 7, 2024
1 parent 9ad5cfd commit 2288480
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions cmd/service-proxy/proxy.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ import (
"sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/controller-runtime/pkg/handler"
"sigs.k8s.io/controller-runtime/pkg/log"
"sigs.k8s.io/controller-runtime/pkg/predicate"

greenhouseapis "github.com/cloudoperators/greenhouse/pkg/apis"
greenhousev1alpha1 "github.com/cloudoperators/greenhouse/pkg/apis/greenhouse/v1alpha1"
Expand Down Expand Up @@ -155,10 +154,9 @@ func (pm *ProxyManager) SetupWithManager(name string, mgr ctrl.Manager) error {
Named(name).
For(&v1.Secret{}, builder.WithPredicates(
clientutil.PredicateFilterBySecretType(greenhouseapis.SecretTypeKubeConfig),
predicate.ResourceVersionChangedPredicate{},
)).
// Watch plugins to be notified about exposed services
Watches(&greenhousev1alpha1.Plugin{}, handler.EnqueueRequestsFromMapFunc(enqueuePluginForCluster), builder.WithPredicates(predicate.Or(predicate.GenerationChangedPredicate{}, predicate.LabelChangedPredicate{}))).
Watches(&greenhousev1alpha1.Plugin{}, handler.EnqueueRequestsFromMapFunc(enqueuePluginForCluster)).
Complete(pm)
}

Expand Down

0 comments on commit 2288480

Please sign in to comment.