-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opentelemetry] adding logs label, fixing ceph parsing #478
base: main
Are you sure you want to change the base?
Conversation
Kuckkuck
commented
Nov 4, 2024
- Fixed ceph log line parsing for resource.attributes["app.label.component"] == "cephobjectstores.ceph.rook.io"
- added label for log.type
- increase memory limit
- more Kubernetes labels from the Kubernetes metadata service
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit from my side.
- id: journal-label | ||
type: add | ||
field: attributes["log.type"] | ||
value: "journald" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are the quotes necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes - for the attributes and the value.
@@ -128,6 +134,9 @@ spec: | |||
- action: insert | |||
key: region | |||
value: "${region}" | |||
- action: insert | |||
key: log.type | |||
value: "k8sevents" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same question :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same answer ;-)