V2/develop #138
Open
V2/develop #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itive-dogu-config Feature/119 only reference sensitive dogu config
They use a reconcilation backoff now. Unfortunately, there is one more health check after applying dogus and before restarting them. This one is still necessary as a blocking health check. This is because if we want a continuous process, we will regenerate the state diff everytime. Therefore, we then have no clue anymore, if we still need to restart some dogus, so we need to do this in the same go as the version change. Problem is, we cannot restart them immediately because this will break the creation of service accounts. Therefore, the health check needs to be in the same go as well and needs to be blocking because of that.
…1-apply-blueprint-continuously
…pply-blueprint-continuously # Conflicts: # pkg/application/blueprintSpecChangeUseCase.go # pkg/bootstrap.go
this way, whe use cases don't need to load the blueprint everytime. If there is an concurrent update, we handle the conflicts when we try to update the blueprint ourselves. If we use the same blueprint the whole time we don't need to recalculate the state diff. We only have to do this, if we need to reconcile the CR again, e.g. for non-blocking health checks.
Otherwise, we would publish dozens of this events because we will validate the blueprint as every reconciliation now
We have a condition instead. We also want to prevent event duplication over multiple reconciles.
We show the effective blueprint in status. There could be thousands of this event if we recalculate the effective blueprint on every reconciliation.
add condition for healthy ecosystem
We removed the maintenance mode. Therefore, the only thing this use case still did, was to check the dry run flag.
In previous versions, the state diff was calculated once and then got persisted in the blueprint CR. Therefore, we had to write all fields there. Now we calculate the state diff at every reconciliation. Because of that we can now decide which fields we want to publish in the blueprint CR.
If the ecosytem is unhealthy, an error is thrown and another reconciliation gets triggered. This way, we repeat the health check until everything is healthy. If the ecosystem is healthy afterward, the post-processing will always run.
We need this later to skip some steps while applying the blueprint.
…nges-when-debug-mode-is-running
This is unnecessary as we don't have a status in the mask.
…mask External blueprint mask
…-config-map-references-for-configuration # Conflicts: # pkg/bootstrap.go
…-config-map-references-for-configuration # Conflicts: # go.mod # go.sum
…rences-for-configuration Feature/136 add config map references for configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.