Skip to content

Conversation

@alexander-dammeier
Copy link
Contributor

@alexander-dammeier alexander-dammeier commented May 22, 2025

resolves #114
resolves #113

  • add additionalMounts
  • extract blueprint CRD into own lib
  • use minVolumeSize for Dogu CRs instead of now deprecated field

alexander-dammeier and others added 27 commits May 12, 2025 15:40
update dependencies for that and
fix go version and
fix mockery and
fix make target
…udogu/k8s-blueprint-operator into feature/113-add-data-mounts-to-dogus
StateDiff was correct in domain.statDiff but was not correctly mapped to crd.stateDiff
StateDiff was correct in domain.statDiff but was not correctly mapped to crd.stateDiff
we now need at least
k8s-dogu-operator-crd 2.8.0-0
because we want so set the new
minDataVolumeSize field in dogu CRs
and prefer the new one over the
deprecated one
remove deprecated DataVolumeSize from
existing Dogu CRs if a patch happens
- fixed markdown links
problem is that serializer will always
generate "0" for minVolSize.
This problem occurred because
we removed the pointer type and
use the struct directly.
…ogus' into feature/113-add-data-mounts-to-dogus
@nhinze23
Copy link
Collaborator

nhinze23 commented May 28, 2025

Dynamic validation is missing:

  • dogu.json volumes
  • Source ConfigMaps and Secrets

@nhinze23
Copy link
Collaborator

And one point i noticed during the manual test:
If the data mount change fails the blueprint health check does not result in an error because only the dogus health state and not the installed state is used. Is this intended?

@alexander-dammeier
Copy link
Contributor Author

alexander-dammeier commented May 28, 2025

Dynamic validation is missing:

  • dogu.json volumes
  • Source ConfigMaps and Secrets

Check for ConfigMaps and Secrets:
As discussed earlier, the plan is to add this validation with the next feature (extracting sensitive config in secrets) because we can implement this in a more general approach.

We cannot just validate if the configmaps etc. exists as we want a declarative approach for blueprints. If something is missing, we need to reconcile the blueprint again with a small backoff. Only this way we can deploy the blueprint together with configMaps and secrets in one go.

also do not pin linter version as it
breaks compatability often.
It is enough to pin the makefile version.
@nhinze23
Copy link
Collaborator

nhinze23 commented Jun 5, 2025

lgtm

@nhinze23 nhinze23 merged commit 1987717 into develop Jun 5, 2025
1 check passed
@nhinze23 nhinze23 deleted the feature/113-add-data-mounts-to-dogus branch June 5, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use new minDataVolumeSize field add addtional mounts for dogus

6 participants