- 
                Notifications
    You must be signed in to change notification settings 
- Fork 0
Feature/113 add data mounts to dogus #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
update dependencies for that and fix go version and fix mockery and fix make target
…udogu/k8s-blueprint-operator into feature/113-add-data-mounts-to-dogus
StateDiff was correct in domain.statDiff but was not correctly mapped to crd.stateDiff
StateDiff was correct in domain.statDiff but was not correctly mapped to crd.stateDiff
we now need at least k8s-dogu-operator-crd 2.8.0-0 because we want so set the new minDataVolumeSize field in dogu CRs
and prefer the new one over the deprecated one
remove deprecated DataVolumeSize from existing Dogu CRs if a patch happens
- fixed markdown links
problem is that serializer will always generate "0" for minVolSize. This problem occurred because we removed the pointer type and use the struct directly.
…ogus' into feature/113-add-data-mounts-to-dogus
| Dynamic validation is missing: 
 | 
| And one point i noticed during the manual test: | 
| 
 Check for ConfigMaps and Secrets: We cannot just validate if the configmaps etc. exists as we want a declarative approach for blueprints. If something is missing, we need to reconcile the blueprint again with a small backoff. Only this way we can deploy the blueprint together with configMaps and secrets in one go. | 
also do not pin linter version as it breaks compatability often. It is enough to pin the makefile version.
At the moment, clients can be just configMaps and they get mounted directly without an empty dir volume etc. Therefore additional mounts cannot work in this case.
this way we don't need to mock the internals of the domain services.
also set the minimum dependency
| lgtm | 
resolves #114
resolves #113