Fix integration tests for ingress-nginx #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nihussmann
force-pushed
the
bug/nginx-integrationtest
branch
from
65b33a6 to
bc5bacc
Compare
schnatterer
changed the title
schnatterer
requested changes
Mar 6, 2025
nihussmann
force-pushed
the
bug/nginx-integrationtest
branch
3 times, most recently
from
458226f to
547699f
Compare
Co-authored-by: Johannes Schnatterer <johannes.schnatterer@cloudogu.com>
schnatterer
force-pushed
the
bug/nginx-integrationtest
branch
from
547699f to
f473ec3
Compare
schnatterer
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed two race condition issues:
The integration test's start condition only checked for the presence of pods, while the test itself validated the Service. However, at that point, the Service was still in the process of being created.
We waited for the node to return its name but did not wait for it to retrieve its IP. This occasionally caused flaky tests due to an empty IP value.